From: Jakub Kicinski <kuba@kernel.org>
To: Sunil Kovvuri <sunil.kovvuri@gmail.com>
Cc: Linux Netdev List <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Michal Kubecek <mkubecek@suse.cz>,
Sunil Goutham <sgoutham@marvell.com>,
Geetha sowjanya <gakula@marvell.com>,
Christina Jacob <cjacob@marvell.com>,
Subbaraya Sundeep <sbhatta@marvell.com>,
Aleksey Makarov <amakarov@marvell.com>
Subject: Re: [PATCH v4 02/17] octeontx2-pf: Mailbox communication with AF
Date: Thu, 23 Jan 2020 06:14:40 -0800 [thread overview]
Message-ID: <20200123061440.171e93f6@cakuba> (raw)
In-Reply-To: <CA+sq2Ce7nFbPu33Cu5YwgfEdfjOSWQwA1nijjtF7KKBYSph1TQ@mail.gmail.com>
On Thu, 23 Jan 2020 00:57:22 +0530, Sunil Kovvuri wrote:
> > I'm slightly concerned about the use of non-iomem helpers like memset
> > and memcpy on what I understand to be IOMEM, and the lack of memory
> > barriers. But then again, I don't know much about iomem_wc(), is this
> > code definitely correct from memory ordering perspective?
> > (The memory barrier in otx2_mbox_msg_send() should probably be just
> > wmb(), syncing with HW is unrelated with SMP.)
>
> The mailbox region is a normal memory which is exposed to two devices
> via PCI BARs.
> And the writeq() call (to trigger IRQ) inside otx2_mbox_msg_send() has a wmb().
Oka, fine, if it works it works, I guess.
next prev parent reply other threads:[~2020-01-23 14:14 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 13:21 [PATCH v4 00/17] octeontx2-pf: Add network driver for physical function sunil.kovvuri
2020-01-21 13:21 ` [PATCH v4 01/17] octeontx2-pf: Add Marvell OcteonTX2 NIC driver sunil.kovvuri
2020-01-21 16:00 ` Jakub Kicinski
2020-01-21 13:21 ` [PATCH v4 02/17] octeontx2-pf: Mailbox communication with AF sunil.kovvuri
2020-01-21 16:00 ` Jakub Kicinski
2020-01-22 19:27 ` Sunil Kovvuri
2020-01-23 14:14 ` Jakub Kicinski [this message]
2020-01-24 8:33 ` Maciej Fijalkowski
2020-01-24 17:15 ` Sunil Kovvuri
2020-01-21 13:21 ` [PATCH v4 03/17] octeontx2-pf: Attach NIX and NPA block LFs sunil.kovvuri
2020-01-21 16:00 ` Jakub Kicinski
2020-01-22 19:27 ` Sunil Kovvuri
2020-01-21 13:21 ` [PATCH v4 04/17] octeontx2-pf: Initialize and config queues sunil.kovvuri
2020-01-21 16:00 ` Jakub Kicinski
2020-01-22 19:29 ` Sunil Kovvuri
2020-01-23 14:20 ` Jakub Kicinski
2020-01-24 11:21 ` Sunil Kovvuri
2020-01-21 13:21 ` [PATCH v4 05/17] octeontx2-pf: Setup interrupts and NAPI handler sunil.kovvuri
2020-01-21 13:21 ` [PATCH v4 06/17] octeontx2-pf: Receive packet handling support sunil.kovvuri
2020-01-21 16:33 ` Jakub Kicinski
2020-01-22 19:34 ` Sunil Kovvuri
2020-01-24 10:14 ` Maciej Fijalkowski
2020-01-21 13:21 ` [PATCH v4 07/17] octeontx2-pf: Add packet transmission support sunil.kovvuri
2020-01-21 16:54 ` Jakub Kicinski
2020-01-22 19:50 ` Sunil Kovvuri
2020-01-23 14:24 ` Jakub Kicinski
2020-01-21 13:21 ` [PATCH v4 08/17] octeontx2-pf: Register and handle link notifications sunil.kovvuri
2020-01-21 13:21 ` [PATCH v4 09/17] octeontx2-pf: MTU, MAC and RX mode config support sunil.kovvuri
2020-01-21 13:21 ` [PATCH v4 10/17] octeontx2-pf: Error handling support sunil.kovvuri
2020-01-21 13:21 ` [PATCH v4 11/17] octeontx2-pf: Receive side scaling support sunil.kovvuri
2020-01-21 13:21 ` [PATCH v4 12/17] octeontx2-pf: TCP segmentation offload support sunil.kovvuri
2020-01-21 13:21 ` [PATCH v4 13/17] octeontx2-pf: Add ndo_get_stats64 sunil.kovvuri
2020-01-21 13:21 ` [PATCH v4 14/17] octeontx2-pf: Add basic ethtool support sunil.kovvuri
2020-01-21 13:21 ` [PATCH v4 15/17] octeontx2-pf: ethtool RSS config support sunil.kovvuri
2020-01-21 13:21 ` [PATCH v4 16/17] Documentation: net: octeontx2: Add RVU HW and drivers overview sunil.kovvuri
2020-01-21 13:21 ` [PATCH v4 17/17] MAINTAINERS: Add entry for Marvell OcteonTX2 Physical Function driver sunil.kovvuri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200123061440.171e93f6@cakuba \
--to=kuba@kernel.org \
--cc=amakarov@marvell.com \
--cc=cjacob@marvell.com \
--cc=davem@davemloft.net \
--cc=gakula@marvell.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=sunil.kovvuri@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox