From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6A17C2D0DB for ; Thu, 23 Jan 2020 12:12:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A76A5206A2 for ; Thu, 23 Jan 2020 12:12:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579781531; bh=R7uMm+UHhjCYHSjldNpA0eQkWxcp2RP7lAFVxMKcHlQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=m1JKLMlGi1yEBa/W7kWmUtL19ZH1wsZHIUAdMI/LA4wX6eiVgoPZ6YCTONjp1TGi9 lRQJYifKvfatA4ov6V3v6WGCIrxm890qx01TeYWsoTdavygE95n8NwwMHprorauDaH ghHc+z6DIf76GVaNh6tb7lKXELgU1xqvmy+z+Pss= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728921AbgAWMMK (ORCPT ); Thu, 23 Jan 2020 07:12:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:60468 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726026AbgAWMMK (ORCPT ); Thu, 23 Jan 2020 07:12:10 -0500 Received: from localhost (unknown [193.47.165.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 05027206A2; Thu, 23 Jan 2020 12:12:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579781529; bh=R7uMm+UHhjCYHSjldNpA0eQkWxcp2RP7lAFVxMKcHlQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bk7fhSUCEnOjtlGY4anE5W2hycTxp3Rm3g2zwqT0J4MEFPUVhN2S0H+FClT0fPmCo AFXTklSZnKfhQufbK/gYW0Aj+ush0mTY1dpwO0OSfYTD68iV47rRUyJogtDwZHIgMo 71r75gJ12mGEixpXp3rLTpHavoqdkGQlwVsHnVyc= Date: Thu, 23 Jan 2020 14:12:03 +0200 From: Leon Romanovsky To: Michal Kalderon Cc: "davem@davemloft.net" , Ariel Elior , "netdev@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "linux-scsi@vger.kernel.org" Subject: Re: [EXT] Re: [PATCH net-next 14/14] qed: bump driver version Message-ID: <20200123121203.GL7018@unreal> References: <20200122152627.14903-1-michal.kalderon@marvell.com> <20200122152627.14903-15-michal.kalderon@marvell.com> <20200122161353.GG7018@unreal> <20200122182107.GI7018@unreal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jan 23, 2020 at 08:18:08AM +0000, Michal Kalderon wrote: > > From: linux-rdma-owner@vger.kernel.org > owner@vger.kernel.org> On Behalf Of Leon Romanovsky > > Sent: Wednesday, January 22, 2020 8:21 PM > > To: Michal Kalderon > > Cc: Ariel Elior ; davem@davemloft.net; > > netdev@vger.kernel.org; linux-rdma@vger.kernel.org; linux- > > scsi@vger.kernel.org > > Subject: Re: [EXT] Re: [PATCH net-next 14/14] qed: bump driver version > > > > On Wed, Jan 22, 2020 at 04:39:26PM +0000, Michal Kalderon wrote: > > > > From: Leon Romanovsky > > > > Sent: Wednesday, January 22, 2020 6:14 PM > > > > > > > > -------------------------------------------------------------------- > > > > -- On Wed, Jan 22, 2020 at 05:26:27PM +0200, Michal Kalderon wrote: > > > > > The FW brings along a large set of fixes and features which will > > > > > be added at a later phase. This is an adaquete point to bump the > > > > > driver > > > > version. > > > > > > > > > > Signed-off-by: Ariel Elior > > > > > Signed-off-by: Michal Kalderon > > > > > --- > > > > > drivers/net/ethernet/qlogic/qed/qed.h | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > > > > We discussed this a lot, those driver version bumps are stupid and > > > > have nothing close to the reality. Distro kernels are based on some > > > > kernel version with extra patches on top, in RedHat world this "extra" > > > > is a lot. For them your driver version say nothing. For users who > > > > run vanilla kernel, those versions are not relevant too, because > > > > running such kernels requires knowledge and understanding. > > > > > > > > You definitely should stop this enterprise cargo cult of "releasing > > software" > > > > by updating versions in non-controlled by you distribution chain. > > > > > > > > Thanks > > > Due to past discussions on this topic, qedr driver version was not added > > and not bumped. > > > However, customers are used to seeing a driver version for qed/qede We > > > only bump major version changes (37 -> 42) and not the minor versions > > anymore. > > > This does give a high-level understanding of the driver supports, helps us > > and the customers. > > > > It is worth to talk with customers instead of adding useless work for > > everyone involved here. > Hi Leon, > > I understand your arguments, and for new drivers I agree it is best to start without a driver version, having said that > Customers are used to what is already out there. > > Ethtool displays a driver version, and customers go by driver version, not kernel version. > Mlx drivers haven't bumped the driver version, but it is still displayed when running ethtool. Yes, it is needed to be fixed. > > Having this version in upstream driver also helps us to understand the level of changes in the inbox driver. > As you mentioned, in some distributions like RHEL, kernel version has no meaning as they backport much newer functionality from upstream. > It is difficult to know based on RedHat kernel/driver, how the driver compares with the upstream driver or what functionality is there. > We have seen that the driver version greatly helps customers here. > > Of course if a decision is taken to remove all ethernet driver versions from all vendors and remove the version display from ethtool > We won't object, but since it is still there, and the driver version until now does correlate in the high-level sense to functionality, > I don't see the harm in this single patch. > > Dave, what is your take on this ? Dave was clear about it. https://lore.kernel.org/linux-rdma/20200122.201241.1054821076123160712.davem@davemloft.net > Thanks, > Michal > > > > > Thanks > > > > >