From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 967F3C35243 for ; Sat, 25 Jan 2020 07:15:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 72F472071E for ; Sat, 25 Jan 2020 07:15:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727680AbgAYHPE (ORCPT ); Sat, 25 Jan 2020 02:15:04 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:48356 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725801AbgAYHPE (ORCPT ); Sat, 25 Jan 2020 02:15:04 -0500 Received: from localhost (unknown [62.209.224.147]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1802715A16D6F; Fri, 24 Jan 2020 23:15:02 -0800 (PST) Date: Sat, 25 Jan 2020 08:15:01 +0100 (CET) Message-Id: <20200125.081501.844064409437176102.davem@davemloft.net> To: mathew.j.martineau@linux.intel.com Cc: netdev@vger.kernel.org, mptcp@lists.01.org, edumazet@google.com Subject: Re: [PATCH net-next 2/2] mptcp: Fix code formatting From: David Miller In-Reply-To: <20200125000403.251894-3-mathew.j.martineau@linux.intel.com> References: <20200125000403.251894-1-mathew.j.martineau@linux.intel.com> <20200125000403.251894-3-mathew.j.martineau@linux.intel.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 24 Jan 2020 23:15:03 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Mat Martineau Date: Fri, 24 Jan 2020 16:04:03 -0800 > checkpatch.pl had a few complaints in the last set of MPTCP patches: > > ERROR: code indent should use tabs where possible > +^I subflow, sk->sk_family, icsk->icsk_af_ops, target, mapped);$ > > CHECK: Comparison to NULL could be written "!new_ctx" > + if (new_ctx == NULL) { > > ERROR: "foo * bar" should be "foo *bar" > +static const struct proto_ops * tcp_proto_ops(struct sock *sk) > > Signed-off-by: Mat Martineau Applied.