* [PATCH] net: stmmac: platform: fix probe for ACPI devices
@ 2020-01-23 1:16 Ajay Gupta
2020-01-25 9:10 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Ajay Gupta @ 2020-01-23 1:16 UTC (permalink / raw)
To: davem, mcoquelin.stm32
Cc: netdev, joabreu, peppe.cavallaro, alexandre.torgue, Ajay Gupta
From: Ajay Gupta <ajayg@nvidia.com>
Use generic device API to get phy mode to fix probe failure
with ACPI based devices.
Signed-off-by: Ajay Gupta <ajayg@nvidia.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
index 4775f49d7f3b..d10ac54bf385 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
@@ -412,9 +412,9 @@ stmmac_probe_config_dt(struct platform_device *pdev, const char **mac)
*mac = NULL;
}
- rc = of_get_phy_mode(np, &plat->phy_interface);
- if (rc)
- return ERR_PTR(rc);
+ plat->phy_interface = device_get_phy_mode(&pdev->dev);
+ if (plat->phy_interface < 0)
+ return ERR_PTR(plat->phy_interface);
plat->interface = stmmac_of_get_mac_mode(np);
if (plat->interface < 0)
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: stmmac: platform: fix probe for ACPI devices
2020-01-23 1:16 [PATCH] net: stmmac: platform: fix probe for ACPI devices Ajay Gupta
@ 2020-01-25 9:10 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-01-25 9:10 UTC (permalink / raw)
To: ajaykuee
Cc: mcoquelin.stm32, netdev, joabreu, peppe.cavallaro,
alexandre.torgue, ajayg
From: Ajay Gupta <ajaykuee@gmail.com>
Date: Wed, 22 Jan 2020 17:16:35 -0800
> From: Ajay Gupta <ajayg@nvidia.com>
>
> Use generic device API to get phy mode to fix probe failure
> with ACPI based devices.
>
> Signed-off-by: Ajay Gupta <ajayg@nvidia.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-25 9:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-23 1:16 [PATCH] net: stmmac: platform: fix probe for ACPI devices Ajay Gupta
2020-01-25 9:10 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).