From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: netdev@vger.kernel.org, ilias.apalodimas@linaro.org,
davem@davemloft.net, lorenzo.bianconi@redhat.com,
brouer@redhat.com
Subject: Re: [PATCH net 2/2] net: socionext: fix xdp_result initialization in netsec_process_rx
Date: Sat, 25 Jan 2020 13:50:56 +0100 [thread overview]
Message-ID: <20200125135056.3bdd4255@carbon> (raw)
In-Reply-To: <6c5c8394590826f4d69172cf31e95d44eae92245.1579952387.git.lorenzo@kernel.org>
On Sat, 25 Jan 2020 12:48:51 +0100
Lorenzo Bianconi <lorenzo@kernel.org> wrote:
> Fix xdp_result initialization in netsec_process_rx in order to not
> increase rx counters if there is no bpf program attached to the xdp hook
> and napi_gro_receive returns GRO_DROP
>
> Fixes: ba2b232108d3c ("net: netsec: add XDP support")
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
> drivers/net/ethernet/socionext/netsec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c
> index 0e12a9856aea..56c0e643f430 100644
> --- a/drivers/net/ethernet/socionext/netsec.c
> +++ b/drivers/net/ethernet/socionext/netsec.c
> @@ -942,8 +942,8 @@ static int netsec_process_rx(struct netsec_priv *priv, int budget)
> struct netsec_de *de = dring->vaddr + (DESC_SZ * idx);
> struct netsec_desc *desc = &dring->desc[idx];
> struct page *page = virt_to_page(desc->addr);
> + u32 xdp_result = NETSEC_XDP_PASS;
As a help to reviewers value is:
#define NETSEC_XDP_PASS 0
> struct sk_buff *skb = NULL;
> - u32 xdp_result = XDP_PASS;
XDP_PASS == 2
> u16 pkt_len, desc_len;
> dma_addr_t dma_handle;
> struct xdp_buff xdp;
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2020-01-25 12:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-25 11:48 [PATCH net 0/2] XDP fixes for socionext driver Lorenzo Bianconi
2020-01-25 11:48 ` [PATCH net 1/2] net: socionext: fix possible user-after-free in netsec_process_rx Lorenzo Bianconi
2020-01-25 12:45 ` Jesper Dangaard Brouer
2020-01-27 8:01 ` Ilias Apalodimas
2020-01-25 11:48 ` [PATCH net 2/2] net: socionext: fix xdp_result initialization " Lorenzo Bianconi
2020-01-25 12:50 ` Jesper Dangaard Brouer [this message]
2020-01-27 8:01 ` Ilias Apalodimas
2020-01-27 10:08 ` [PATCH net 0/2] XDP fixes for socionext driver David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200125135056.3bdd4255@carbon \
--to=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=ilias.apalodimas@linaro.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).