From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40EF3C2D0DB for ; Sat, 25 Jan 2020 15:34:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 16E742071A for ; Sat, 25 Jan 2020 15:34:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="pDIorN8G" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726545AbgAYPeI (ORCPT ); Sat, 25 Jan 2020 10:34:08 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:54080 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725710AbgAYPeH (ORCPT ); Sat, 25 Jan 2020 10:34:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ZDYNRqwBExDRXRR1MBnllajpDkmWN72OefXMTvnpJxM=; b=pDIorN8GkvUAsYHcE3q9XkvtTH mOTju6Vz+39zitPiVfOOFlVO3gk1nnvmtxsftHXu6kBK+clKmN4Qs49LI426KGZjMaXrfkaWd0Blw dp9dEIcx9aDhwQIwJF/SpK5+tY3ght5DlnK+0dqsmyZbsUKcV11klQ5fU5csoI+uVJp4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1ivNRj-0006wc-7X; Sat, 25 Jan 2020 16:34:03 +0100 Date: Sat, 25 Jan 2020 16:34:03 +0100 From: Andrew Lunn To: Horatiu Vultur Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bridge@lists.linux-foundation.org, jiri@resnulli.us, ivecera@redhat.com, davem@davemloft.net, roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com, anirudh.venkataramanan@intel.com, olteanv@gmail.com, jeffrey.t.kirsher@intel.com, UNGLinuxDriver@microchip.com Subject: Re: [RFC net-next v3 04/10] net: bridge: mrp: Add generic netlink interface to configure MRP Message-ID: <20200125153403.GB18311@lunn.ch> References: <20200124161828.12206-1-horatiu.vultur@microchip.com> <20200124161828.12206-5-horatiu.vultur@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200124161828.12206-5-horatiu.vultur@microchip.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Jan 24, 2020 at 05:18:22PM +0100, Horatiu Vultur wrote: > Implement the generic netlink interface to configure MRP. The implementation > will do sanity checks over the attributes and then eventually call the MRP > interface which eventually will call the switchdev API. Hi Horatiu What was your thinking between adding a new generic netlink interface, and extending the current one? I've not looked at your user space code yet, but i assume it has to make use of both? It needs to create the bridge and add the interfaces. And then it needs to control the MRP state. Allan mentioned you might get around to implementing 802.1CB? Would that be another generic netlink interface, or would you extend the MRP interface? Thanks Andrew