From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 752D6C35247 for ; Sun, 26 Jan 2020 08:19:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 367732083E for ; Sun, 26 Jan 2020 08:19:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="vY8KB5IY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729138AbgAZITp (ORCPT ); Sun, 26 Jan 2020 03:19:45 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:48247 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726438AbgAZITp (ORCPT ); Sun, 26 Jan 2020 03:19:45 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id D9E0E21EC3; Sun, 26 Jan 2020 03:19:43 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 26 Jan 2020 03:19:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=OwfykH ST6emhj2qWXbkJDIvppm6lZI4tYBHZDFu02j4=; b=vY8KB5IY8uC3RgCweCMkct Ts7HKVZonwawtRHzi7wVju60LoK3uPkvMx+h4GR9XARhiQX6+loHiOGlIv3Lpbqv eP4Lz0KIxnekEMxlgCtmdWLbIQLNJM6PFY1bg6VO3BwJhL4kxb2InqhzgByY7BnA 3RuhQZ86tzsYhgBgxXAMCkaC/gbxRBa5f+x55axdUGZRgYNtvK7tVtAqJyErJnON 90ZLLxJjv3caQflx4eqfI6C3Ne7YLzC4vuqMbOGONuYQktE6i4L5GJJHvvH6ne7s RmXlfb8Z5VscKzuaOSBFYyBP9809ZVXJFqLdLcbhuAjAviU/HTj4S1n1cJMtxtpQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrvdelgddvgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepkfguohcuufgt hhhimhhmvghluceoihguohhstghhsehiughoshgthhdrohhrgheqnecukfhppeduleefrd egjedrudeihedrvdehudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgr ihhlfhhrohhmpehiughoshgthhesihguohhstghhrdhorhhg X-ME-Proxy: Received: from localhost (unknown [193.47.165.251]) by mail.messagingengine.com (Postfix) with ESMTPA id 3B81430673CF; Sun, 26 Jan 2020 03:19:43 -0500 (EST) Date: Sun, 26 Jan 2020 10:19:41 +0200 From: Ido Schimmel To: Christophe JAILLET Cc: jiri@mellanox.com, idosch@mellanox.com, davem@davemloft.net, vadimp@mellanox.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] mlxsw: minimal: Fix an error handling path in 'mlxsw_m_port_create()' Message-ID: <20200126081941.GA794072@splinter> References: <20200125211847.12755-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200125211847.12755-1-christophe.jaillet@wanadoo.fr> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Jan 25, 2020 at 10:18:47PM +0100, Christophe JAILLET wrote: > An 'alloc_etherdev()' called is not ballanced by a corresponding > 'free_netdev()' call in one error handling path. > > Slighly reorder the error handling code to catch the missed case. > > Fixes: c100e47caa8e ("mlxsw: minimal: Add ethtool support") > Signed-off-by: Christophe JAILLET For net: Reviewed-by: Ido Schimmel Thanks!