From: Kalle Valo <kvalo@codeaurora.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Manikanta Pubbisetty <mpubbise@codeaurora.org>,
John Crispin <john@phrozen.org>,
Sven Eckelmann <seckelmann@datto.com>,
Bhagavathi Perumal S <bperumal@codeaurora.org>,
Anilkumar Kolli <akolli@codeaurora.org>,
Arnd Bergmann <arnd@arndb.de>,
Ganesh Sesetti <gseset@codeaurora.org>,
Govindaraj Saminathan <gsamin@codeaurora.org>,
Julia Lawall <julia.lawall@lip6.fr>,
Karthikeyan Periyasamy <periyasa@codeaurora.org>,
kbuild test robot <lkp@intel.com>,
Maharaja Kennadyrajan <mkenna@codeaurora.org>,
Miles Hu <milehu@codeaurora.org>,
Muna Sinada <msinada@codeaurora.org>,
Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>,
Rajkumar Manoharan <rmanohar@codeaurora.org>,
Sathishkumar Muruganandam <murugana@codeaurora.org>,
Shashidhar Lakkavalli <slakkavalli@datto.com>,
Sriram R <srirrama@codeaurora.org>,
Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>,
Venkateswara Naralasetty <vnaralas@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
Tamizh chelvam <tamizhr@codeaurora.org>,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ath11k: fix debugfs build failure
Date: Sun, 26 Jan 2020 10:37:43 +0000 (UTC) [thread overview]
Message-ID: <20200126103743.83EBBC433A2@smtp.codeaurora.org> (raw)
In-Reply-To: <20200107215036.1333983-1-arnd@arndb.de>
Arnd Bergmann <arnd@arndb.de> wrote:
> When CONFIG_ATH11K_DEBUGFS is disabled, but CONFIG_MAC80211_DEBUGFS
> is turned on, the driver fails to build:
>
> drivers/net/wireless/ath/ath11k/debugfs_sta.c: In function 'ath11k_dbg_sta_open_htt_peer_stats':
> drivers/net/wireless/ath/ath11k/debugfs_sta.c:416:4: error: 'struct ath11k' has no member named 'debug'
> ar->debug.htt_stats.stats_req = stats_req;
> ^~
>
> It appears that just using the former symbol is sufficient here,
> adding a Kconfig dependency takes care of the corner cases.
>
> Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
a45ceea5015d ath11k: fix debugfs build failure
--
https://patchwork.kernel.org/patch/11321921/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-01-26 10:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 21:50 [PATCH] ath11k: fix debugfs build failure Arnd Bergmann
2020-01-26 10:37 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200126103743.83EBBC433A2@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=akolli@codeaurora.org \
--cc=arnd@arndb.de \
--cc=ath11k@lists.infradead.org \
--cc=bperumal@codeaurora.org \
--cc=davem@davemloft.net \
--cc=gsamin@codeaurora.org \
--cc=gseset@codeaurora.org \
--cc=john@phrozen.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lkp@intel.com \
--cc=milehu@codeaurora.org \
--cc=mkenna@codeaurora.org \
--cc=mpubbise@codeaurora.org \
--cc=msinada@codeaurora.org \
--cc=murugana@codeaurora.org \
--cc=netdev@vger.kernel.org \
--cc=periyasa@codeaurora.org \
--cc=pradeepc@codeaurora.org \
--cc=rmanohar@codeaurora.org \
--cc=seckelmann@datto.com \
--cc=slakkavalli@datto.com \
--cc=srirrama@codeaurora.org \
--cc=tamizhr@codeaurora.org \
--cc=vnaralas@codeaurora.org \
--cc=vthiagar@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).