From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4567DC35240 for ; Sun, 26 Jan 2020 10:37:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C7792071E for ; Sun, 26 Jan 2020 10:37:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="CamIuXty" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729352AbgAZKhq (ORCPT ); Sun, 26 Jan 2020 05:37:46 -0500 Received: from mail25.static.mailgun.info ([104.130.122.25]:63966 "EHLO mail25.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729145AbgAZKhq (ORCPT ); Sun, 26 Jan 2020 05:37:46 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1580035065; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=Z75vo15kFHSAjpOh8gqvQcI40tUdEQ8bAOEe2NzjOZg=; b=CamIuXtyG6gfcFid4409AgzfidGlhfRrURfpDH9Rkp6luGKv1ECYrICsVNz6JMdfPbVki6Ov 0pqB0kCAo6Ygvz5USifcqF/Fb6nIa8yImMa4OxKZE6BdGiXLqWGynMPIBkA2CQdPuv0rbHd2 j9JQwvmkn6NDA1SbLq2EGZ/2XkE= X-Mailgun-Sending-Ip: 104.130.122.25 X-Mailgun-Sid: WyJiZjI2MiIsICJuZXRkZXZAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e2d6bf7.7fb04d30e810-smtp-out-n02; Sun, 26 Jan 2020 10:37:43 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 83EBBC433A2; Sun, 26 Jan 2020 10:37:43 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id E43F3C433CB; Sun, 26 Jan 2020 10:37:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E43F3C433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ath11k: fix debugfs build failure From: Kalle Valo In-Reply-To: <20200107215036.1333983-1-arnd@arndb.de> References: <20200107215036.1333983-1-arnd@arndb.de> To: Arnd Bergmann Cc: Manikanta Pubbisetty , John Crispin , Sven Eckelmann , Bhagavathi Perumal S , Anilkumar Kolli , Arnd Bergmann , Ganesh Sesetti , Govindaraj Saminathan , Julia Lawall , Karthikeyan Periyasamy , kbuild test robot , Maharaja Kennadyrajan , Miles Hu , Muna Sinada , Pradeep Kumar Chitrapu , Rajkumar Manoharan , Sathishkumar Muruganandam , Shashidhar Lakkavalli , Sriram R , Vasanthakumar Thiagarajan , Venkateswara Naralasetty , "David S. Miller" , Tamizh chelvam , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20200126103743.83EBBC433A2@smtp.codeaurora.org> Date: Sun, 26 Jan 2020 10:37:43 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Arnd Bergmann wrote: > When CONFIG_ATH11K_DEBUGFS is disabled, but CONFIG_MAC80211_DEBUGFS > is turned on, the driver fails to build: > > drivers/net/wireless/ath/ath11k/debugfs_sta.c: In function 'ath11k_dbg_sta_open_htt_peer_stats': > drivers/net/wireless/ath/ath11k/debugfs_sta.c:416:4: error: 'struct ath11k' has no member named 'debug' > ar->debug.htt_stats.stats_req = stats_req; > ^~ > > It appears that just using the former symbol is sufficient here, > adding a Kconfig dependency takes care of the corner cases. > > Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") > Signed-off-by: Arnd Bergmann > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. a45ceea5015d ath11k: fix debugfs build failure -- https://patchwork.kernel.org/patch/11321921/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches