From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F07A2C35247 for ; Sun, 26 Jan 2020 10:54:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C7A6A20842 for ; Sun, 26 Jan 2020 10:54:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580036068; bh=DV1e5XI83L9xgMJppGfP3HTCWwFdC/rEXOwVi5kioy8=; h=From:To:Cc:Subject:Date:List-ID:From; b=gO+XHyhrsGxxhqnn1DP6qzO3bBwgrRWOMHpVuP0t3A+AUaa7RRVOigbzWeVNRpphv e1cD+Fis5MX89FbJT+N+gud0R/q5ziYcgSHUYm2cNH1O36apIrYcOdnXtF8ZJT7y3I bfLyOq1ybofhPtnL7ocec4IUlZ44ABhpb2pbQF5g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729393AbgAZKy1 (ORCPT ); Sun, 26 Jan 2020 05:54:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:44030 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726571AbgAZKy1 (ORCPT ); Sun, 26 Jan 2020 05:54:27 -0500 Received: from localhost (unknown [193.47.165.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 301CC2075D; Sun, 26 Jan 2020 10:54:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580036066; bh=DV1e5XI83L9xgMJppGfP3HTCWwFdC/rEXOwVi5kioy8=; h=From:To:Cc:Subject:Date:From; b=hVvimlsWqEoYkQCCFQNyY4fcgnUT9qgra6FgvmjrjGtvUtJtlAFcIhKOqXO/OJhwH 5zKhTBrq+ReWA7nV4P5nr0HSxk3ff5f5kGHOtXtfle7C4y/FkQpiSbydG/FpaQzl82 w8AmigFKrbmcKkN2r9EjYj4MAbWNIL+aQ8t9GC/E= From: Leon Romanovsky To: "David S. Miller" , Jakub Kicinski , Florian Fainelli Cc: Leon Romanovsky , Michal Kalderon , linux-netdev , RDMA mailing list Subject: [PATCH net-next v3] net/core: Replace driver version to be kernel version Date: Sun, 26 Jan 2020 12:54:22 +0200 Message-Id: <20200126105422.86969-1-leon@kernel.org> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Leon Romanovsky In order to stop useless driver version bumps and unify output presented by ethtool -i, let's overwrite the version string. As Linus said in [1]: "Things are supposed to be backwards and forwards compatible, because we don't accept breakage in user space anyway. So versioning is pointless, and only causes problems." They cause problems when users start to see version changes and expect specific set of features which will be different for stable@, vanilla and distribution kernels. Distribution kernels are based on some kernel version with extra patches on top, for example, in RedHat world this "extra" is a lot and for them the driver version say nothing. Users who run vanilla kernels won't use driver version information too, because running such kernels requires knowledge and understanding. Another set of problems are related to difference in versioning scheme and such doesn't allow to write meaningful automation which will work sanely on all ethtool capable devices. Before this change: [leonro@erver ~]$ ethtool -i eth0 driver: virtio_net version: 1.0.0 After this change: [leonro@server ~]$ ethtool -i eth0 driver: virtio_net version: 5.5.0-rc6+ Link: https://lore.kernel.org/ksummit-discuss/CA+55aFx9A=5cc0QZ7CySC4F2K7eYaEfzkdYEc9JaNgCcV25=rg@mail.gmail.com/ Link: https://lore.kernel.org/linux-rdma/20200122152627.14903-1-michal.kalderon@marvell.com/T/#md460ff8f976c532a89d6860411c3c50bb811038b Signed-off-by: Leon Romanovsky --- Changelog: v3: Used wrong target branch, changed from rdma-next to net-next. v2: https://lore.kernel.org/linux-rdma/20200126100124.86014-1-leon@kernel.org Updated commit message. v1: https://lore.kernel.org/linux-rdma/20200125161401.40683-1-leon@kernel.org Resend per-Dave's request https://lore.kernel.org/linux-rdma/20200125.101311.1924780619716720495.davem@davemloft.net No changes at all and applied cleanly on top of "3333e50b64fe Merge branch 'mlxsw-Offload-TBF'" v0: https://lore.kernel.org/linux-rdma/20200123130541.30473-1-leon@kernel.org --- net/ethtool/ioctl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c index 182bffbffa78..a403decacb6d 100644 --- a/net/ethtool/ioctl.c +++ b/net/ethtool/ioctl.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include @@ -666,6 +667,8 @@ static noinline_for_stack int ethtool_get_drvinfo(struct net_device *dev, return -EOPNOTSUPP; } + strlcpy(info.version, UTS_RELEASE, sizeof(info.version)); + /* * this method of obtaining string set info is deprecated; * Use ETHTOOL_GSSET_INFO instead. -- 2.24.1