From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE20AC2D0DB for ; Mon, 27 Jan 2020 14:51:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A439C20716 for ; Mon, 27 Jan 2020 14:51:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="V8y4z9fu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729305AbgA0Ov3 (ORCPT ); Mon, 27 Jan 2020 09:51:29 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:56078 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726635AbgA0Ov3 (ORCPT ); Mon, 27 Jan 2020 09:51:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=XhfMsVONMq1GlEnz3UKz8jb69fs6RfdWw5Dn3X7mvYg=; b=V8y4z9fuelY302DWTQ8dgVLBP+ +6LshB1sn4p1pGZGhzUxn6Kw+ALaFQtc5mxbKTVZq7wUMJFhvW3MsO4BrzIYdUrgjXbINKTUWpqJN qi/yy8k8Mu1YDoNxtu9q20+xuKFTG7sqQebXPbIeDt/r0daRnnCNVwt78r36jtiVYOC4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1iw5jH-0006nz-Gd; Mon, 27 Jan 2020 15:51:07 +0100 Date: Mon, 27 Jan 2020 15:51:07 +0100 From: Andrew Lunn To: Russell King - ARM Linux admin Cc: Jose Abreu , "netdev@vger.kernel.org" , Joao Pinto , Giuseppe Cavallaro , Alexandre Torgue , "David S. Miller" , Jakub Kicinski , Maxime Coquelin , Florian Fainelli , Heiner Kallweit , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [RFC net-next 6/8] net: phylink: Configure MAC/PCS when link is up without PHY Message-ID: <20200127145107.GE13647@lunn.ch> References: <9a2136885d9a892ff170be88fdffeda82c778a10.1580122909.git.Jose.Abreu@synopsys.com> <20200127112102.GT25745@shell.armlinux.org.uk> <20200127114600.GU25745@shell.armlinux.org.uk> <20200127140038.GD13647@lunn.ch> <20200127140834.GW25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200127140834.GW25745@shell.armlinux.org.uk> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > Can you give a hint which platform this is and how to reproduce it > please? Hi Russell Devel C has issues with its fibre ports. I tend to test with sff2/port9 not sff3/port3, because i also have the copper port plugged in. If the copper gets link before the fibre, copper is used. What i see is that after the SERDES syncs, its registers indicate a 1G link, full duplex, etc. But the MAC is using 10/Half. And hence no packets go through. If i set the MAC to the same as the PCS, i can at least transmit. Receive does not work, but i think that is something else. The statistics counters indicate the SERDES is receiving frames, but the MAC statistic counters suggests the MAC never sees them. I've also had issues with the DSA links, also being configured to 10/Half. That seems to be related to having a phy-mode property in device tree. I need to add a fixed-link property to set the correct speed. Something is broken here, previously the fixed-link was only needed if the speed needed to be lower than the ports maximum. I think that is a separate issue i need to dig into, not part of the PCS to MAC transfer. Heiner has another device which has an Aquantia PHY running in an odd mode so that it does 1G over a T2 link. It uses SGMII for this, and that is where we first noticed the issue of the MAC and PCS having different configurations. Andrew