From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47FF4C35240 for ; Tue, 28 Jan 2020 04:04:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1780C2173E for ; Tue, 28 Jan 2020 04:04:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580184288; bh=BVthqpyqOp3qdMjZ8J/rplJXLhtT0jntt9WRiFrsMCg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=sotHa8uXphN4jzuqsJWsRmXAZtl89Wb+pynPMf0+d7eyliazVr73Get2OPB8rQVRq tyG1IYlBod7WEe3TUU5pfyPZIgA6Q8HIZEmayGsFMwgs7X87NfhbthhwHei/oOoxAJ GnD1EaQ+Y/dK6FxR/HiSsPmuBvPQoASyWY7M4mg8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726541AbgA1EEr (ORCPT ); Mon, 27 Jan 2020 23:04:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:56848 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726191AbgA1EEr (ORCPT ); Mon, 27 Jan 2020 23:04:47 -0500 Received: from cakuba (c-73-93-4-247.hsd1.ca.comcast.net [73.93.4.247]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 797D52173E; Tue, 28 Jan 2020 04:04:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580184286; bh=BVthqpyqOp3qdMjZ8J/rplJXLhtT0jntt9WRiFrsMCg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OFCQ9wwvCNGvtrnXYO/7hCyjLebNAiBoNPYHL6pG+NsuS117nDf9VC+QO6+6wC/Tl 7WXPXEhuvvFfbex3xLlROfHPI8XTXmnWJ3mfEYzWukMbr3FAB38+3pmV7AY+cZEFQI wIPLDHTk8Nk6+BOAI/KNuBdAfr2+ZJuUFONj06Zs= Date: Mon, 27 Jan 2020 20:04:45 -0800 From: Jakub Kicinski To: Taehee Yoo Cc: davem@davemloft.net, netdev@vger.kernel.org Subject: Re: [PATCH net v2 3/6] netdevsim: fix stack-out-of-bounds in nsim_dev_debugfs_init() Message-ID: <20200127200445.760e34ee@cakuba> In-Reply-To: <20200127143034.1367-1-ap420073@gmail.com> References: <20200127143034.1367-1-ap420073@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 27 Jan 2020 14:30:34 +0000, Taehee Yoo wrote: > When netdevsim dev is being created, a debugfs directory is created. > The variable "dev_ddir_name" is 16bytes device name pointer and device > name is "netdevsim". > The maximum dev id length is 10. > So, 16bytes for device name isn't enough. > Fixes: ab1d0cc004d7 ("netdevsim: change debugfs tree topology") > Signed-off-by: Taehee Yoo Reviewed-by: Jakub Kicinski