From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA287C35240 for ; Tue, 28 Jan 2020 04:05:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ADB962173E for ; Tue, 28 Jan 2020 04:05:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580184324; bh=fpVkEgj5XojtInMJQc7EHSKL9y5sM7zJXM/u8UZYXTA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=t1LrWr2pf536zD6sG6V5rMq27dzR9FmG1pRP9bUH+FxgSi8sI0/pf+/mhdkjZLa92 bvcj9gUVAIVhlF9q+UpXOM0b0TKhi3o03hGX3zskJPHzIq56Nrx4lO8lqDFm83zqQS xOuphqXGME8V9R765zbpmB5oFoTcg1ZFZBYPyEA0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726612AbgA1EFY (ORCPT ); Mon, 27 Jan 2020 23:05:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:56904 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726191AbgA1EFX (ORCPT ); Mon, 27 Jan 2020 23:05:23 -0500 Received: from cakuba (c-73-93-4-247.hsd1.ca.comcast.net [73.93.4.247]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0010C2173E; Tue, 28 Jan 2020 04:05:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580184323; bh=fpVkEgj5XojtInMJQc7EHSKL9y5sM7zJXM/u8UZYXTA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=taiw4PAn6Sm4GwohdhOApt28v6P6fUL09nnLzwkH0J9zfKYhFHuaoJhagOqDy6xZ2 TCX5rT2hLo7m9/0xp6c736APXCFKZWu3GwrxLqP0GdXEru5CuDzEU02scgI05Hdb1A eW6yXkVfq89mB2wDe9opg7TkGKcJ+zTkhLeljeOI= Date: Mon, 27 Jan 2020 20:05:22 -0800 From: Jakub Kicinski To: Taehee Yoo Cc: davem@davemloft.net, netdev@vger.kernel.org Subject: Re: [PATCH net v2 5/6] netdevsim: use __GFP_NOWARN to avoid memalloc warning Message-ID: <20200127200522.3bff7eb6@cakuba> In-Reply-To: <20200127143053.1550-1-ap420073@gmail.com> References: <20200127143053.1550-1-ap420073@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 27 Jan 2020 14:30:53 +0000, Taehee Yoo wrote: > vfnum buffer size and binary_len buffer size is received by user-space. > So, this buffer size could be too large. If so, kmalloc will internally > print a warning message. > This warning message is actually not necessary for the netdevsim module. > So, this patch adds __GFP_NOWARN. > Fixes: 79579220566c ("netdevsim: add SR-IOV functionality") > Fixes: 82c93a87bf8b ("netdevsim: implement couple of testing devlink health reporters") > Signed-off-by: Taehee Yoo Reviewed-by: Jakub Kicinski