From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Jouni Högander" <jouni.hogander@unikie.com>
Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
open list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ben Hutchings <ben.hutchings@codethink.co.uk>,
linux- stable <stable@vger.kernel.org>,
Netdev <netdev@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
syzkaller@googlegroups.com
Subject: Re: [PATCH 4.19 000/306] 4.19.87-stable review
Date: Tue, 28 Jan 2020 14:29:41 +0100 [thread overview]
Message-ID: <20200128132941.GA2956977@kroah.com> (raw)
In-Reply-To: <87zhe727uo.fsf@unikie.com>
On Tue, Jan 28, 2020 at 12:28:15PM +0200, Jouni Högander wrote:
> Hello Greg,
>
> jouni.hogander@unikie.com (Jouni Högander) writes:
>
> > Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> >>> > Now queued up, I'll push out -rc2 versions with this fix.
> >>> >
> >>> > greg k-h
> >>>
> >>> We have also been informed about another regression these two commits
> >>> are causing:
> >>>
> >>> https://lore.kernel.org/lkml/ace19af4-7cae-babd-bac5-cd3505dcd874@I-love.SAKURA.ne.jp/
> >>>
> >>> I suggest to drop these two patches from this queue, and give us a
> >>> week to shake out the regressions of the change, and once ready, we
> >>> can include the complete set of fixes to stable (probably in a week or
> >>> two).
> >>
> >> Ok, thanks for the information, I've now dropped them from all of the
> >> queues that had them in them.
> >>
> >> greg k-h
> >
> > I have now run more extensive Syzkaller testing on following patches:
> >
> > cb626bf566eb net-sysfs: Fix reference count leak
> > ddd9b5e3e765 net-sysfs: Call dev_hold always in rx_queue_add_kobject
> > e0b60903b434 net-sysfs: Call dev_hold always in netdev_queue_add_kobje
> > 48a322b6f996 net-sysfs: fix netdev_queue_add_kobject() breakage
> > b8eb718348b8 net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject
> >
> > These patches are fixing couple of memory leaks including this one found
> > by Syzbot: https://syzkaller.appspot.com/bug?extid=ad8ca40ecd77896d51e2
> >
> > I can reproduce these memory leaks in following stable branches: 4.14,
> > 4.19, and 5.4.
> >
> > These are all now merged into net/master tree and based on my testing
> > they are ready to be taken into stable branches as well.
> >
> > Best Regards,
> >
> > Jouni Högander
>
> These four patches are still missing from 4.14 and 4.19 branches:
>
> ddd9b5e3e765 net-sysfs: Call dev_hold always in rx_queue_add_kobject
> e0b60903b434 net-sysfs: Call dev_hold always in netdev_queue_add_kobje
> 48a322b6f996 net-sysfs: fix netdev_queue_add_kobject() breakage
> b8eb718348b8 net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject
>
> Could you please consider taking them in or let me know if you want some
> further activities from my side?
Thanks for the list, I have now queued these all up.
greg k-h
next prev parent reply other threads:[~2020-01-28 13:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191127203114.766709977@linuxfoundation.org>
2019-11-28 6:53 ` [PATCH 4.19 000/306] 4.19.87-stable review Naresh Kamboju
2019-11-28 7:36 ` Greg Kroah-Hartman
2019-11-28 15:56 ` shuah
2019-11-28 23:57 ` shuah
2019-11-29 6:43 ` Greg Kroah-Hartman
2019-11-29 5:46 ` Lukas Bulwahn
2019-11-29 8:58 ` Greg Kroah-Hartman
2020-01-22 7:48 ` Jouni Högander
2020-01-26 11:54 ` Lukas Bulwahn
2020-01-27 8:42 ` Jouni Högander
2020-01-27 21:16 ` Lukas Bulwahn
2020-01-28 8:46 ` Jouni Högander
2020-01-28 10:28 ` Jouni Högander
2020-01-28 13:29 ` Greg Kroah-Hartman [this message]
2019-11-29 8:54 ` Naresh Kamboju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200128132941.GA2956977@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=ben.hutchings@codethink.co.uk \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jouni.hogander@unikie.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=syzkaller@googlegroups.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).