From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEBC4C33CB2 for ; Wed, 29 Jan 2020 10:57:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7E5582064C for ; Wed, 29 Jan 2020 10:57:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="pvIxPeo7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726186AbgA2K5O (ORCPT ); Wed, 29 Jan 2020 05:57:14 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:38948 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726067AbgA2K5O (ORCPT ); Wed, 29 Jan 2020 05:57:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=/ZFMtqqol7eFnZfCWpoSSjEmgXpVt9jrMtqoDKVehag=; b=pvIxPeo7+9fmKM0RXNZHct4lS p/1nkNvglrNo+JfaXQEH06zg+kVUYUx0svw3KLbyEL3BJH4wl3kzwQF5zQB+EbxpDFO1S1u+6GWUj ebWsOVzNLWYrYNmIOZ5iOi5NPrqRRGSLIWM7HJ++1IZmmONFwiGw4v0YqGdl4iqxxs4GKUGqVL/tf d758KfAs4h6NOtfHwL0uspbLlA3CcKuppkNfIfxrvsCMobbSRrkA2VrIfAmUeQKyeVJXV/ehVryAv 62SL2GRBDiIJYmkMY9Jv4y3oQnKPFbXB8CxmfvL68qA73dwSZPV2+gdgYuLX1sIckb2dlRCwblcIp biNGe5WsA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44848) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iwl1r-0004wG-Rg; Wed, 29 Jan 2020 10:57:04 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1iwl1o-0003Kr-I2; Wed, 29 Jan 2020 10:57:00 +0000 Date: Wed, 29 Jan 2020 10:57:00 +0000 From: Russell King - ARM Linux admin To: "Madalin Bucur (OSS)" Cc: Vladimir Oltean , Florian Fainelli , "davem@davemloft.net" , "andrew@lunn.ch" , "hkallweit1@gmail.com" , "netdev@vger.kernel.org" , "ykaukab@suse.de" Subject: Re: [PATCH net-next 1/2] net: phy: aquantia: add rate_adaptation indication Message-ID: <20200129105700.GF25745@shell.armlinux.org.uk> References: <1579701573-6609-1-git-send-email-madalin.bucur@oss.nxp.com> <1579701573-6609-2-git-send-email-madalin.bucur@oss.nxp.com> <68921c8a-06b6-d5c0-e857-14e7bc2c0a94@gmail.com> <77e3ddcb-bddb-32d8-9c87-48ba9a7f2773@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jan 29, 2020 at 10:53:03AM +0000, Madalin Bucur (OSS) wrote: > Meanwhile, a real issue is that in the current design, the > ethernet driver needs to remove modes that are invalid from the PHY > advertising, but needs to refrain from doing that when coupled with > a PHY that does rate adaptation. This bit provides just an indication > of that ability. That should be phylink's job, not the ethernet driver. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up