From: Andrew Lunn <andrew@lunn.ch>
To: "Madalin Bucur (OSS)" <madalin.bucur@oss.nxp.com>
Cc: Vladimir Oltean <olteanv@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"ykaukab@suse.de" <ykaukab@suse.de>,
Russell King - ARM Linux admin <linux@armlinux.org.uk>
Subject: Re: [PATCH net-next 1/2] net: phy: aquantia: add rate_adaptation indication
Date: Wed, 29 Jan 2020 14:44:47 +0100 [thread overview]
Message-ID: <20200129134447.GA25384@lunn.ch> (raw)
In-Reply-To: <DB8PR04MB6985B0A712634DCFCD5390A4EC050@DB8PR04MB6985.eurprd04.prod.outlook.com>
> I know it is set because someone does put some work in designing a system,
> in provisioning a correct firmware image.
Hi Madalin
That is one of the things i don't like about the aquantia PHY. It can
have all sorts of magic in its firmware, but the firmware is specific
to the board. Is this phydev->rate_adaptation going to be correct for
any other board using an Aquantia PHY?
I think at least you need to poke around in the Aquantia PHY registers
and ensure this feature is actually enabled before setting this bit to
true.
Andrew
next prev parent reply other threads:[~2020-01-29 13:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 13:59 [PATCH net-next 0/2] net: phy: aquantia: indicate rate adaptation Madalin Bucur
2020-01-22 13:59 ` [PATCH net-next 1/2] net: phy: aquantia: add rate_adaptation indication Madalin Bucur
2020-01-22 17:58 ` Florian Fainelli
2020-01-23 7:38 ` Madalin Bucur (OSS)
2020-01-27 17:42 ` Florian Fainelli
2020-01-28 7:02 ` Madalin Bucur (OSS)
2020-01-28 15:55 ` Vladimir Oltean
2020-01-29 9:38 ` Madalin Bucur (OSS)
2020-01-29 10:15 ` Vladimir Oltean
2020-01-29 10:53 ` Madalin Bucur (OSS)
2020-01-29 10:57 ` Russell King - ARM Linux admin
2020-01-29 10:59 ` Madalin Bucur (OSS)
2020-01-29 11:57 ` Vladimir Oltean
2020-01-29 12:47 ` Madalin Bucur
2020-01-29 13:44 ` Andrew Lunn [this message]
2020-01-29 14:36 ` Madalin Bucur (OSS)
2020-01-29 15:33 ` Andrew Lunn
2020-01-30 9:40 ` Madalin Bucur (OSS)
2020-01-22 13:59 ` [PATCH net-next 2/2] dpaa_eth: support all modes with rate adapting PHYs Madalin Bucur
2020-01-22 20:05 ` Heiner Kallweit
2020-01-23 7:20 ` Madalin Bucur (OSS)
2020-01-29 13:34 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200129134447.GA25384@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=madalin.bucur@oss.nxp.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=ykaukab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).