netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: <netdev@vger.kernel.org>
Cc: matthieu.baerts@tessares.net, mathew.j.martineau@linux.intel.com
Subject: [PATCH net 0/4] mptcp: fix sockopt crash and lockdep splats
Date: Wed, 29 Jan 2020 15:54:42 +0100	[thread overview]
Message-ID: <20200129145446.26425-1-fw@strlen.de> (raw)

Christoph Paasch reported a few bugs and lockdep splats triggered by
syzkaller.

One patch fixes a crash in set/getsockopt.
Two patches fix lockdep splats related to the order in which RTNL
and socket lock are taken.

Last patch fixes out-of-bounds access when TCP syncookies are used.

Change since last iteration on mptcp-list:
 - add needed refcount in patch 2
 - call tcp_get/setsockopt directly in patch 2

 Other patches unchanged except minor amends to commit messages.

 include/linux/tcp.h   |  2 --
 net/ipv4/syncookies.c |  4 ++++
 net/ipv4/tcp_input.c  |  3 +++
 net/ipv6/syncookies.c |  3 +++
 net/mptcp/protocol.c  | 54 ++++++++++++++++++++++++++++++++----------------------
 net/mptcp/subflow.c   |  5 ++++-
 6 files changed, 46 insertions(+), 25 deletions(-)




             reply	other threads:[~2020-01-29 14:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-29 14:54 Florian Westphal [this message]
2020-01-29 14:54 ` [PATCH net 1/4] mptcp: defer freeing of cached ext until last moment Florian Westphal
2020-01-29 14:54 ` [PATCH net 2/4] mptcp: fix panic on user pointer access Florian Westphal
2020-01-29 14:54 ` [PATCH net 3/4] mptcp: avoid a lockdep splat when mcast group was joined Florian Westphal
2020-01-29 14:54 ` [PATCH net 4/4] mptcp: handle tcp fallback when using syn cookies Florian Westphal
2020-01-29 16:47 ` [PATCH net 0/4] mptcp: fix sockopt crash and lockdep splats David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200129145446.26425-1-fw@strlen.de \
    --to=fw@strlen.de \
    --cc=mathew.j.martineau@linux.intel.com \
    --cc=matthieu.baerts@tessares.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).