From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBF5EC35240 for ; Thu, 30 Jan 2020 13:41:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C2B472083E for ; Thu, 30 Jan 2020 13:41:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727228AbgA3Nly convert rfc822-to-8bit (ORCPT ); Thu, 30 Jan 2020 08:41:54 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:45753 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727125AbgA3Nlx (ORCPT ); Thu, 30 Jan 2020 08:41:53 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-8-ilKwKLf5Ng6J2SLpUVZx-g-1; Thu, 30 Jan 2020 08:41:48 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 21DB7107ACC5; Thu, 30 Jan 2020 13:41:46 +0000 (UTC) Received: from bistromath.localdomain (ovpn-117-110.ams2.redhat.com [10.36.117.110]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 340EC5DA7B; Thu, 30 Jan 2020 13:41:42 +0000 (UTC) Date: Thu, 30 Jan 2020 14:41:41 +0100 From: Sabrina Dubroca To: Oliver Hartkopp Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, syzbot+c3ea30e1e2485573f953@syzkaller.appspotmail.com, dvyukov@google.com, mkl@pengutronix.de, j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net, davem@davemloft.net, linux-stable Subject: Re: [PATCH] bonding: do not enslave CAN devices Message-ID: <20200130134141.GA804563@bistromath.localdomain> References: <20200130133046.2047-1-socketcan@hartkopp.net> MIME-Version: 1.0 In-Reply-To: <20200130133046.2047-1-socketcan@hartkopp.net> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: ilKwKLf5Ng6J2SLpUVZx-g-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: queasysnail.net Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello, 2020-01-30, 14:30:46 +0100, Oliver Hartkopp wrote: > Since commit 8df9ffb888c ("can: make use of preallocated can_ml_priv for per > device struct can_dev_rcv_lists") the device specific CAN receive filter lists > are stored in netdev_priv() and dev->ml_priv points to these filters. > > In the bug report Syzkaller enslaved a vxcan1 CAN device and accessed the > bonding device with a PF_CAN socket which lead to a crash due to an access of > an unhandled bond_dev->ml_priv pointer. > > Deny to enslave CAN devices by the bonding driver as the resulting bond_dev > pretends to be a CAN device by copying dev->type without really being one. Does the team driver have the same problem? -- Sabrina