From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BE24C2D0DB for ; Fri, 31 Jan 2020 18:07:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7355921734 for ; Fri, 31 Jan 2020 18:07:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580494029; bh=mNhBHwh7/sbcu8F+2HAdjn4r7FE6MDpmO6dgSRi1EYQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=MDlqduVuK266H2AKIC8h1BM6IPiqVO+Q31jc5SiwS6StHQ25Hy2Wrdu+tiYtBSk7R +BlR+2ZDN/RdyLpRuWW11HAFootNzpurcMBqM7JD5GWqI/y17ZzSe8EtT77dLV5jb2 /WG8rWAAW0173Rebcza6QStx2Gm+5MnjxH+OYLE4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727219AbgAaSHI (ORCPT ); Fri, 31 Jan 2020 13:07:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:59400 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726712AbgAaSHI (ORCPT ); Fri, 31 Jan 2020 13:07:08 -0500 Received: from cakuba.hsd1.ca.comcast.net (unknown [199.201.64.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B92A320663; Fri, 31 Jan 2020 18:07:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580494028; bh=mNhBHwh7/sbcu8F+2HAdjn4r7FE6MDpmO6dgSRi1EYQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=eCWJgbk8Oa3fFh32Q9gIoicPJIBajhYaPQWh3yfmv5eg4oK2x8wlfofuyIr5s3KlB kIsSYtwYeIcznqiQBwXbm9JPOi6j2KcoAIX71k1d2+C6liiBQzEHahmpfNVT5NbHuq c5maUOfttGjeFNQZng03Tym9KONbTED/qvYL2PYA= Date: Fri, 31 Jan 2020 10:07:06 -0800 From: Jakub Kicinski To: Jacob Keller Cc: netdev@vger.kernel.org, jiri@resnulli.us, valex@mellanox.com, linyunsheng@huawei.com, lihong.yang@intel.com Subject: Re: [PATCH 02/15] devlink: add functions to take snapshot while locked Message-ID: <20200131100706.5c98981e@cakuba.hsd1.ca.comcast.net> In-Reply-To: <20200130225913.1671982-3-jacob.e.keller@intel.com> References: <20200130225913.1671982-1-jacob.e.keller@intel.com> <20200130225913.1671982-3-jacob.e.keller@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 30 Jan 2020 14:58:57 -0800, Jacob Keller wrote: > +static int > +devlink_region_snapshot_create_locked(struct devlink_region *region, > + u8 *data, u32 snapshot_id, > + devlink_snapshot_data_dest_t *destructor) -1 on the _locked suffix. Please follow the time-honored tradition of using double underscore for internal helpers which make assumption about calling context. > +{ > + struct devlink_snapshot *snapshot; lockdep_assert_held() is much better than just a kdoc comment. > + /* check if region can hold one more snapshot */ > + if (region->cur_snapshots == region->max_snapshots) > + return -ENOMEM;