From: Andrew Lunn <andrew@lunn.ch>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ajay Gupta <ajayg@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Iyappan Subramanian <iyappan@os.amperecomputing.com>,
Keyur Chudgar <keyur@os.amperecomputing.com>,
Quan Nguyen <quan@os.amperecomputing.com>,
Steve Glendinning <steve.glendinning@shawell.net>,
Jassi Brar <jaswinder.singh@linaro.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net] device property: change device_get_phy_mode() to prevent signedess bugs
Date: Fri, 31 Jan 2020 14:57:46 +0100 [thread overview]
Message-ID: <20200131135746.GF9639@lunn.ch> (raw)
In-Reply-To: <20200131045953.wbj66jkvijnmf5s2@kili.mountain>
> diff --git a/drivers/net/ethernet/apm/xgene-v2/main.c b/drivers/net/ethernet/apm/xgene-v2/main.c
> index c48f60996761..706602918dd1 100644
> --- a/drivers/net/ethernet/apm/xgene-v2/main.c
> +++ b/drivers/net/ethernet/apm/xgene-v2/main.c
> @@ -15,7 +15,7 @@ static int xge_get_resources(struct xge_pdata *pdata)
> {
> struct platform_device *pdev;
> struct net_device *ndev;
> - int phy_mode, ret = 0;
> + int ret = 0;
> struct resource *res;
> struct device *dev;
Hi Dan
DaveM likes reverse christmas tree. So you need to move ret later to
keep the tree.
Apart from that:
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2020-01-31 13:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 4:59 [PATCH net] device property: change device_get_phy_mode() to prevent signedess bugs Dan Carpenter
2020-01-31 8:12 ` Andy Shevchenko
2020-01-31 8:48 ` Andy Shevchenko
2020-01-31 8:15 ` Andy Shevchenko
2020-01-31 8:24 ` Dan Carpenter
2020-01-31 13:57 ` Andrew Lunn [this message]
2020-02-03 0:15 ` kbuild test robot
2020-02-03 0:16 ` kbuild test robot
2020-02-03 5:11 ` kbuild test robot
2020-03-11 5:53 ` Calvin Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200131135746.GF9639@lunn.ch \
--to=andrew@lunn.ch \
--cc=ajayg@nvidia.com \
--cc=alexandre.torgue@st.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=ilias.apalodimas@linaro.org \
--cc=iyappan@os.amperecomputing.com \
--cc=jaswinder.singh@linaro.org \
--cc=joabreu@synopsys.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=keyur@os.amperecomputing.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=quan@os.amperecomputing.com \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).