From: Andrew Lunn <andrew@lunn.ch>
To: Calvin Johnson <calvin.johnson@nxp.com>
Cc: linux.cj@gmail.com, Jon Nettleton <jon@solid-run.com>,
linux@armlinux.org.uk, Makarand Pawagi <makarand.pawagi@nxp.com>,
cristian.sovaiala@nxp.com, laurentiu.tudor@nxp.com,
ioana.ciornei@nxp.com, V.Sethi@nxp.com, pankaj.bansal@nxp.com,
"Rajesh V . Bikkina" <rajesh.bikkina@nxp.com>,
Marcin Wojtas <mw@semihalf.com>,
Calvin Johnson <calvin.johnson@oss.nxp.com>,
"David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v1 1/7] mdio_bus: Introduce fwnode MDIO helpers
Date: Fri, 31 Jan 2020 17:28:14 +0100 [thread overview]
Message-ID: <20200131162814.GB17185@lunn.ch> (raw)
In-Reply-To: <20200131153440.20870-2-calvin.johnson@nxp.com>
On Fri, Jan 31, 2020 at 09:04:34PM +0530, Calvin Johnson wrote:
> From: Marcin Wojtas <mw@semihalf.com>
>
> This patch introduces fwnode helper for registering MDIO
> bus, as well as one for finding the PHY, basing on its
> firmware node pointer. Comparing to existing OF equivalent,
> fwnode_mdiobus_register() does not support:
> * deprecated bindings (device whitelist, nor the PHY ID embedded
> in the compatible string)
> * MDIO bus auto scanning
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> Signed-off-by: Calvin Johnson <calvin.johnson@oss.nxp.com>
Hi Calvin
This appears to but a cut and paste, follow by an intelligent
s/of/fwnode/g.
Did you make any attempt to consolidate the two implementations? It
seems like there should be some level of abstraction that hides away
the difference between DT properties, and DT properties stuffed into
ACPI tables?
Andrew
next prev parent reply other threads:[~2020-01-31 16:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 15:34 [PATCH v1 0/7] ACPI support for xgmac_mdio and dpaa2-mac drivers Calvin Johnson
2020-01-31 15:34 ` [PATCH v1 1/7] mdio_bus: Introduce fwnode MDIO helpers Calvin Johnson
2020-01-31 16:28 ` Andrew Lunn [this message]
2020-02-05 7:11 ` [EXT] " Calvin Johnson (OSS)
2020-02-03 9:49 ` kbuild test robot
2020-02-05 14:17 ` Jeremy Linton
2020-02-07 9:42 ` [EXT] " Calvin Johnson (OSS)
2020-03-17 11:36 ` Calvin Johnson
2020-03-17 14:04 ` Andrew Lunn
2020-03-18 6:03 ` Calvin Johnson
2020-01-31 15:34 ` [PATCH v1 2/7] mdio_bus: modify fwnode phy related functions Calvin Johnson
2020-01-31 15:34 ` [PATCH v1 3/7] net/fsl: add ACPI support for mdio bus Calvin Johnson
2020-01-31 16:08 ` Andy Shevchenko
2020-02-04 7:18 ` Calvin Johnson (OSS)
2020-02-04 11:17 ` Andy Shevchenko
2020-02-03 3:44 ` Florian Fainelli
2020-02-04 18:46 ` Calvin Johnson
2020-01-31 15:34 ` [PATCH v1 4/7] device property: fwnode_get_phy_mode: Change API to solve int/unit warnings Calvin Johnson
2020-01-31 15:55 ` Andy Shevchenko
2020-02-03 9:13 ` Calvin Johnson (OSS)
2020-02-03 9:22 ` Andy Shevchenko
2020-02-03 2:32 ` kbuild test robot
2020-02-03 8:41 ` kbuild test robot
2020-01-31 15:34 ` [PATCH v1 6/7] net: phylink: Introduce phylink_fwnode_phy_connect() Calvin Johnson
2020-02-03 18:21 ` kbuild test robot
2020-02-03 18:41 ` Russell King - ARM Linux admin
2020-02-03 18:43 ` Russell King - ARM Linux admin
2020-02-05 11:33 ` [EXT] " Calvin Johnson (OSS)
2020-01-31 15:34 ` [PATCH v1 7/7] dpaa2-eth: Add ACPI support for DPAA2 MAC driver Calvin Johnson
2020-02-03 18:02 ` [PATCH v1 0/7] ACPI support for xgmac_mdio and dpaa2-mac drivers Florian Fainelli
2020-02-05 8:31 ` [EXT] " Calvin Johnson (OSS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200131162814.GB17185@lunn.ch \
--to=andrew@lunn.ch \
--cc=V.Sethi@nxp.com \
--cc=calvin.johnson@nxp.com \
--cc=calvin.johnson@oss.nxp.com \
--cc=cristian.sovaiala@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=jon@solid-run.com \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.cj@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=makarand.pawagi@nxp.com \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=pankaj.bansal@nxp.com \
--cc=rajesh.bikkina@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).