From: Ivan Vecera <ivecera@redhat.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: poros@redhat.com, netdev@vger.kernel.org, andrew@lunn.ch,
f.fainelli@gmail.com
Subject: Re: [PATCH net v2] phy: avoid unnecessary link-up delay in polling mode
Date: Sat, 1 Feb 2020 11:25:54 +0100 [thread overview]
Message-ID: <20200201112554.6d2b3a53@ceranb> (raw)
In-Reply-To: <414b2dc1-2421-e4c8-ea81-1177545fb327@gmail.com>
On Fri, 31 Jan 2020 21:50:48 +0100
Heiner Kallweit <hkallweit1@gmail.com> wrote:
> > 0x7949
> > [ 24.154174] xgene-mii-rgmii:03: genphy_update_link(), line: 1927, link: 0
> >
> > . supressed 3 same messages in T0+1,2,3s
> >
> > [ 28.609822] xgene-mii-rgmii:03: genphy_update_link(), line: 1895, link: 0
> > [ 28.629906] xgene-mii-rgmii:03: genphy_update_link(), line: 1917, status:
> > 0x7969
> > ^^^^^^^^^^^^^^^ detected BMSR_ANEGCOMPLETE but not BMSR_LSTATUS
> > [ 28.644590] xgene-mii-rgmii:03: genphy_update_link(), line: 1921, status:
> > 0x796d
> > ^^^^^^^^^^^^^^^ here is detected BMSR_ANEGCOMPLETE and BMSR_LSTATUS
> > [ 28.658681] xgene-mii-rgmii:03: genphy_update_link(), line: 1927, link: 1
> >
>
> I see, thanks. Strange behavior of the PHY. Did you test also with other PHY's
> whether they behave the same?
Yeah, it's strange... we could try different PHYs but anyway the double read was
removed for polling mode to detect momentary link drops but it make sense only
when phy->link is not 0. Thoughts?
Ivan
next prev parent reply other threads:[~2020-02-01 10:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 10:13 [PATCH net] phy: avoid unnecessary link-up delay in polling mode Petr Oros
2020-01-29 11:18 ` Ivan Vecera
2020-01-29 12:06 ` Ivan Vecera
2020-01-29 12:15 ` David Miller
2020-01-29 12:23 ` Petr Oros
2020-01-29 12:19 ` [PATCH net v2] " Petr Oros
2020-01-29 21:01 ` Heiner Kallweit
2020-01-31 15:09 ` Petr Oros
2020-01-31 20:50 ` Heiner Kallweit
2020-02-01 10:25 ` Ivan Vecera [this message]
2020-02-01 20:26 ` Heiner Kallweit
2020-02-02 14:49 ` Ivan Vecera
2020-02-18 9:35 ` [PATCH net-next] " Petr Oros
2020-02-18 20:45 ` Heiner Kallweit
2020-02-20 0:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200201112554.6d2b3a53@ceranb \
--to=ivecera@redhat.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=poros@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).