RE: [PATCH 2/3] can: m_can: m_can_platform: Add support for enabling transceiver through the STB line

Sriram Dash
2020-01-22T14:54:09Z

> From: linux-can-owner@vger.kernel.org <linux-can-owner@vger.kernel.org> On
> Behalf Of Faiz Abbas
> Subject: [PATCH 2/3] can: m_can: m_can_platform: Add support for enabling
> transceiver through the STB line
>
> CAN transceivers on some boards have an STB (standby) line which can be
> toggled to enable/disable the transceiver. Add support for enabling the
> transceiver using a GPIO connected to the STB line.
>

Looks good to me.
Other than Dan's concern on stb as standby,
Acked-by: Sriram Dash <sriram.dash@samsung.com>

> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
> ---
> drivers/net/can/m_can/m_can_platform.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/net/can/m_can/m_can_platform.c
> b/drivers/net/can/m_can/m_can_platform.c
> index 38ea5e600fb8..b4e1423bd5d8 100644
> --- a/drivers/net/can/m_can/m_can_platform.c
> +++ b/drivers/net/can/m_can/m_can_platform.c
> @@ -6,6 +6,7 @@
> // Copyright (C) 2018-19 Texas Instruments Incorporated -
http://www.ti.com/
>
> #include <linux/platform_device.h>
> +#include <linux/gpio/consumer.h>
>
> #include "m_can.h"
>
> @@ -57,6 +58,7 @@ static int m_can_plat_probe(struct platform_device
*pdev)
> {
> struct m_can_classdev *mcan_class;
> struct m_can_plat_priv *priv;
> + struct gpio_desc *stb;
> struct resource *res;
> void __iomem *addr;
> void __iomem *mram_addr;
> @@ -111,6 +113,16 @@ static int m_can_plat_probe(struct platform_device
> *pdev)
>
> m_can_init_ram(mcan_class);
>
> + stb = devm_gpiod_get_optional(&pdev->dev, "stb", GPIOD_OUT_HIGH);
> + if (IS_ERR(stb)) {
> + ret = PTR_ERR(stb);
> + if (ret != -EPROBE_DEFER)
> + dev_err(&pdev->dev,
> + "gpio request failed, ret %d\n", ret);
> +
> + goto failed_ret;
> + }
> +
> ret = m_can_class_register(mcan_class);
>
> failed_ret:
> --
> 2.19.2