From: Guillaume Nault <gnault@redhat.com>
To: Ridge Kennedy <ridge.kennedy@alliedtelesis.co.nz>
Cc: netdev@vger.kernel.org, tparkin@katalix.com, jchapman@katalix.com
Subject: Re: [PATCH v2 net] l2tp: Allow duplicate session creation with UDP
Date: Tue, 4 Feb 2020 13:09:12 +0100 [thread overview]
Message-ID: <20200204120912.GA20493@pc-61.home> (raw)
In-Reply-To: <20200203232400.28981-1-ridge.kennedy@alliedtelesis.co.nz>
On Tue, Feb 04, 2020 at 12:24:00PM +1300, Ridge Kennedy wrote:
> In the past it was possible to create multiple L2TPv3 sessions with the
> same session id as long as the sessions belonged to different tunnels.
> The resulting sessions had issues when used with IP encapsulated tunnels,
> but worked fine with UDP encapsulated ones. Some applications began to
> rely on this behaviour to avoid having to negotiate unique session ids.
>
> Some time ago a change was made to require session ids to be unique across
> all tunnels, breaking the applications making use of this "feature".
>
> This change relaxes the duplicate session id check to allow duplicates
> if both of the colliding sessions belong to UDP encapsulated tunnels.
>
Thanks Ridge.
Even though it's already applied,
Reviewed-by: Guillaume Nault <gnault@redhat.com>
Tested-by: Guillaume Nault <gnault@redhat.com>
prev parent reply other threads:[~2020-02-04 12:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 23:24 [PATCH v2 net] l2tp: Allow duplicate session creation with UDP Ridge Kennedy
2020-02-04 10:27 ` James Chapman
2020-02-04 11:39 ` David Miller
2020-02-04 12:09 ` Guillaume Nault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200204120912.GA20493@pc-61.home \
--to=gnault@redhat.com \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
--cc=ridge.kennedy@alliedtelesis.co.nz \
--cc=tparkin@katalix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox