From: Dominique Martinet <asmadeus@codewreck.org>
To: Sergey Alirzaev <l29ah@cock.li>
Cc: v9fs-developer@lists.sourceforge.net,
Eric Van Hensbergen <ericvh@gmail.com>,
Latchesar Ionkov <lucho@ionkov.net>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] 9p: read only once on O_NONBLOCK
Date: Wed, 5 Feb 2020 08:41:44 +0100 [thread overview]
Message-ID: <20200205074144.GB16626@nautica> (raw)
In-Reply-To: <20200205003457.24340-2-l29ah@cock.li>
Sergey Alirzaev wrote on Wed, Feb 05, 2020:
> A proper way to handle O_NONBLOCK would be making the requests and
> responses happen asynchronously, but this would require serious code
> refactoring.
FWIW I do have some async 9p code waiting (it's been sent to the list
ages ago but I never took the time to properly test it due to lack of
interest manifested), the problem here is more the caching model than a
synchronous issue, since in nocache mode (where this is used) there is
nowhere to fetch the data ahead of time.
If you're interested in that then please have a look at
https://lore.kernel.org/lkml/1544532108-21689-1-git-send-email-asmadeus@codewreck.org/
> Signed-off-by: Sergey Alirzaev <l29ah@cock.li>
That aside, I guess, why not?
Will take when other patch gets addressed.
Thanks,
--
Dominique
next prev parent reply other threads:[~2020-02-05 7:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 0:34 [PATCH 1/2] 9pnet: allow making incomplete read requests Sergey Alirzaev
2020-02-05 0:34 ` [PATCH 2/2] 9p: read only once on O_NONBLOCK Sergey Alirzaev
2020-02-05 7:41 ` Dominique Martinet [this message]
2020-02-05 7:35 ` [PATCH 1/2] 9pnet: allow making incomplete read requests Dominique Martinet
2020-02-05 15:48 ` l29ah
2020-02-05 16:07 ` Dominique Martinet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200205074144.GB16626@nautica \
--to=asmadeus@codewreck.org \
--cc=davem@davemloft.net \
--cc=ericvh@gmail.com \
--cc=kuba@kernel.org \
--cc=l29ah@cock.li \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=netdev@vger.kernel.org \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox