From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FAKE_REPLY_C,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CED16C352A2 for ; Fri, 7 Feb 2020 04:11:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9C8C02064C for ; Fri, 7 Feb 2020 04:11:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="vOes9tra"; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="VW7WjaSY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727442AbgBGEL5 (ORCPT ); Thu, 6 Feb 2020 23:11:57 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:44672 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726674AbgBGEL5 (ORCPT ); Thu, 6 Feb 2020 23:11:57 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 01744AWp173421; Fri, 7 Feb 2020 04:11:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=Uzkw3Dme7vW7Do23tVP5PYKy5jL7rEfCTSz69KsQAfo=; b=vOes9tracP3bVQJ89vQaoG54tzEphz8IRfXYLTy3UuH0PQo98O3d9HlpcO1Ht5aAExxN nwSDKJeFwunWt5cUgAHV2hrPkamK3Z9u9Mi/h4iacueveGQoV31RERzHfR6Itz7n/47e jqE1i1Hb+RS9dEp54ZBIENw/LuIEqD1ml+Y5DVPtK54325riVZeXaHVXCjkwmDmiurx0 Szhg+hVQp79OslyPEdFbLFPX6phS2LQHj0pHzWJIGHMoF0wzf1N+ua8v03DlWawCBNV6 Kvl8Ds3AyfXUNZG9r3UesQvhTkndjhZdq5Y8DpodUkfXZ67zcBLLtMyhkzInby4tu0YW 7g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=Uzkw3Dme7vW7Do23tVP5PYKy5jL7rEfCTSz69KsQAfo=; b=VW7WjaSY90j7fbjERaJfocVgcic9L5fqjjvgzWPqx1DgLBVB+PmdZ3TI2vUEOp5sbTlY +8+/yfe9lkVP1XPTaBSvofxEK7o/g3RY4iyFo6qtejtZg6dK9fVSVM4yqHISTGn69TGD e3TpSBwCk8VmcApvPT6WisiwNGOV08s7lRHyrapq9ouqRVJ/DmVWRm5OvnCmBYJpiNPI hRtGAMLODI7rncwvR1U96S6NbwG9YGWIZvp/uyY9ClAJY1VchTbDNKrIOBXuJ3gaTMei wI8TY0KuBJ94KwNHRjFt7RFo51iwA4zmnnyPXygFUt9RlKhuCCizYLc0QT9kqEqggnxd ig== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 2xykbpdm9b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 07 Feb 2020 04:11:40 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 01744JrK137490; Fri, 7 Feb 2020 04:11:40 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3020.oracle.com with ESMTP id 2y0jg0ejcv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 07 Feb 2020 04:11:40 +0000 Received: from abhmp0020.oracle.com (abhmp0020.oracle.com [141.146.116.26]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0174BZCZ019805; Fri, 7 Feb 2020 04:11:36 GMT Received: from kadam (/129.205.23.165) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 06 Feb 2020 20:11:34 -0800 Date: Fri, 7 Feb 2020 07:11:23 +0300 From: Dan Carpenter To: kbuild@lists.01.org, Kai-Heng Feng Cc: kbuild-all@lists.01.org, davem@davemloft.ne, mkubecek@suse.cz, jeffrey.t.kirsher@intel.com, "open list:NETWORKING DRIVERS" , Kai-Heng Feng , "moderated list:INTEL ETHERNET DRIVERS" , "David S. Miller" , open list Subject: Re: [Intel-wired-lan] [PATCH v2 1/2] igb: Use device_lock() insead of rtnl_lock() Message-ID: <20200207041123.GO24804@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200205081616.18378-1-kai.heng.feng@canonical.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9523 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2002070025 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9523 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2002070025 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Kai-Heng, url: https://github.com/0day-ci/linux/commits/Kai-Heng-Feng/igb-Use-device_lock-insead-of-rtnl_lock/20200205-174208 base: https://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git dev-queue If you fix the issue, kindly add following tag Reported-by: kbuild test robot Reported-by: Dan Carpenter New smatch warnings: drivers/net/ethernet/intel/igb/igb_main.c:4036 igb_close() warn: inconsistent returns 'dev->mutex'. # https://github.com/0day-ci/linux/commit/905877ae7d44efc1d9c5c1ae9f4489f56bcb13a6 git remote add linux-review https://github.com/0day-ci/linux git remote update linux-review git checkout 905877ae7d44efc1d9c5c1ae9f4489f56bcb13a6 vim +4036 drivers/net/ethernet/intel/igb/igb_main.c 9d5c824399dea8 drivers/net/igb/igb_main.c Auke Kok 2008-01-24 4026 46eafa59e18d03 drivers/net/ethernet/intel/igb/igb_main.c Stefan Assmann 2016-02-03 4027 int igb_close(struct net_device *netdev) 749ab2cd127046 drivers/net/ethernet/intel/igb/igb_main.c Yan, Zheng 2012-01-04 4028 { 905877ae7d44ef drivers/net/ethernet/intel/igb/igb_main.c Kai-Heng Feng 2020-02-05 4029 struct igb_adapter *adapter = netdev_priv(netdev); 905877ae7d44ef drivers/net/ethernet/intel/igb/igb_main.c Kai-Heng Feng 2020-02-05 4030 struct device *dev = &adapter->pdev->dev; 905877ae7d44ef drivers/net/ethernet/intel/igb/igb_main.c Kai-Heng Feng 2020-02-05 4031 905877ae7d44ef drivers/net/ethernet/intel/igb/igb_main.c Kai-Heng Feng 2020-02-05 4032 device_lock(dev); 888f22931478a0 drivers/net/ethernet/intel/igb/igb_main.c Lyude Paul 2017-12-12 4033 if (netif_device_present(netdev) || netdev->dismantle) 749ab2cd127046 drivers/net/ethernet/intel/igb/igb_main.c Yan, Zheng 2012-01-04 4034 return __igb_close(netdev, false); ^^^^^^ Lock held for this return. 905877ae7d44ef drivers/net/ethernet/intel/igb/igb_main.c Kai-Heng Feng 2020-02-05 4035 device_unlock(dev); 9474933caf21a4 drivers/net/ethernet/intel/igb/igb_main.c Todd Fujinaka 2016-11-15 @4036 return 0; 749ab2cd127046 drivers/net/ethernet/intel/igb/igb_main.c Yan, Zheng 2012-01-04 4037 } 749ab2cd127046 drivers/net/ethernet/intel/igb/igb_main.c Yan, Zheng 2012-01-04 4038 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation