netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "Per Förlin" <Per.Forlin@axis.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"john@phrozen.org" <john@phrozen.org>,
	"f.fainelli@gmail.com" <f.fainelli@gmail.com>
Subject: Re: [Question] net: dsa: tag_qca: QCA tag and headroom size?
Date: Thu, 13 Feb 2020 13:53:32 +0100	[thread overview]
Message-ID: <20200213125332.GA2814@lunn.ch> (raw)
In-Reply-To: <1581571438638.7622@axis.com>

On Thu, Feb 13, 2020 at 05:23:59AM +0000, Per Förlin wrote:
> 
> > > -     if (skb_cow_head(skb, 0) < 0)
> > > >  Is it really safe to assume there is enough headroom for the QCA tag?
> > >
> > > +     if (skb_cow_head(skb, QCA_HDR_LEN) < 0)
> > > > My proposal. Specify QCA tag size to make sure there is headroom.
> > >
> > >               return NULL;
> > >
> > >       skb_push(skb, QCA_HDR_LEN);
> 
> > > Hi Per
> 
> > > Yes, your change looks correct. ar9331_tag_xmit() also seems to have
> > > the same problem.
> 
> >> Do you want to submit a patch?
> Thanks for your response,

> I can submit a patch on both drivers, however I only have hardware
> to perform an actual test on the QCA switch.

Hi Per

That is fine. This should be low risk. Cc: Oleksij Rempel
<kernel@pengutronix.de> when you post the patch, so he can review and
test it.

Thanks
	Andrew

      reply	other threads:[~2020-02-13 12:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-12  9:57 [Question] net: dsa: tag_qca: QCA tag and headroom size? Per Förlin
2020-02-12 20:23 ` Andrew Lunn
2020-02-13  5:23   ` Per Förlin
2020-02-13 12:53     ` Andrew Lunn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200213125332.GA2814@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Per.Forlin@axis.com \
    --cc=f.fainelli@gmail.com \
    --cc=john@phrozen.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).