netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Per@axis.com, Forlin <per.forlin@axis.com>
Cc: netdev@vger.kernel.org, o.rempel@pengutronix.de,
	davem@davemloft.net, Per Forlin <per.forlin@axis.com>,
	Per Forlin <perfn@axis.com>
Subject: Re: [PATCH net 1/2] net: dsa: tag_qca: Make sure there is headroom for tag
Date: Thu, 13 Feb 2020 15:01:32 +0100	[thread overview]
Message-ID: <20200213140132.GC12151@lunn.ch> (raw)
In-Reply-To: <20200213135100.2963-2-per.forlin@axis.com>

On Thu, Feb 13, 2020 at 02:50:59PM +0100, Per@axis.com wrote:
> From: Per Forlin <per.forlin@axis.com>
> 
> Passing tag size to skb_cow_head will make sure
> there is enough headroom for the tag data.
> This change does not introduce any overhead in case there
> is already available headroom for tag.
> 
> Signed-off-by: Per Forlin <perfn@axis.com>

Hi Per

If these are for net, you need a Fixes: tag.

Also, you should add the Reivewed-by: tags i gave for these patches.

      Andrew

  reply	other threads:[~2020-02-13 14:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-13 13:50 [PATCH net 0/2] net: dsa: Make sure there is headroom for tag Per, Forlin <per.forlin
2020-02-13 13:50 ` [PATCH net 1/2] net: dsa: tag_qca: " Per, Forlin <per.forlin
2020-02-13 14:01   ` Andrew Lunn [this message]
2020-02-13 15:08     ` Per Förlin
2020-02-13 13:51 ` [PATCH net 2/2] net: dsa: tag_ar9331: " Per, Forlin <per.forlin
2020-02-13 13:59   ` Oleksij Rempel
2020-02-13 14:42     ` Per Förlin
2020-02-13 14:26   ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2020-02-13 14:37 [PATCH net 0/2] net: dsa: " Per Forlin
2020-02-13 14:37 ` [PATCH net 1/2] net: dsa: tag_qca: " Per Forlin
2020-02-13 20:02   ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200213140132.GC12151@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Per@axis.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=per.forlin@axis.com \
    --cc=perfn@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).