Re: [PATCH net v2] net: virtio_vsock: Enhance connection semantics

Stefano Garzarella
2020-02-14T10:40:21Z

On Fri, Feb 14, 2020 at 10:23:44AM +0000, Boeuf, Sebastien wrote:
> On Fri, 2020-02-14 at 10:17 +0100, Stefano Garzarella wrote:
> > Hi Sebastien,
> > the patch and the test look good to me!
> > I tested with virtio and VMCI transports and your test works great,
> > thanks!
>
> I'm glad everything worked out well so quickly :)

:)

>
> >
> > I suggest split the patch in two, one for the fix and one for the
> > test.
>
> Ok will do!
>
> >
> > Are you using git format-patch / git send-email?
> > I fought a little bit to apply it because of CRLF ;-)
>
> Well I have been using evolution mail client, but I'm gonna use the
> proper way with git send-email.

A very useful tool is the Stefan's git-publish:
https://github.com/stefanha/git-publish

>
> One question though, if I split this into 2 patches, I need to write a
> cover letter?

Yes, it is better.

Just a brief description of the series and its patches.

Thanks,
Stefano