public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Stefano Garzarella <sgarzare@redhat.com>
To: "Boeuf, Sebastien" <sebastien.boeuf@intel.com>
Cc: "stefanha@redhat.com" <stefanha@redhat.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH net v2] net: virtio_vsock: Enhance connection semantics
Date: Fri, 14 Feb 2020 11:40:09 +0100	[thread overview]
Message-ID: <20200214104009.id33ew3uznvmitsb@steredhat> (raw)
In-Reply-To: <28f00ab8065e1abedbfd4e198b0ed0bb8ba93ef4.camel@intel.com>

On Fri, Feb 14, 2020 at 10:23:44AM +0000, Boeuf, Sebastien wrote:
> On Fri, 2020-02-14 at 10:17 +0100, Stefano Garzarella wrote:
> > Hi Sebastien,
> > the patch and the test look good to me!
> > I tested with virtio and VMCI transports and your test works great,
> > thanks!
> 
> I'm glad everything worked out well so quickly :)

:)

> 
> > 
> > I suggest split the patch in two, one for the fix and one for the
> > test.
> 
> Ok will do!
> 
> > 
> > Are you using git format-patch / git send-email?
> > I fought a little bit to apply it because of CRLF ;-)
> 
> Well I have been using evolution mail client, but I'm gonna use the
> proper way with git send-email.

A very useful tool is the Stefan's git-publish:
https://github.com/stefanha/git-publish

> 
> One question though, if I split this into 2 patches, I need to write a
> cover letter?

Yes, it is better.

Just a brief description of the series and its patches.

Thanks,
Stefano


      reply	other threads:[~2020-02-14 10:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-13 18:31 [PATCH net v2] net: virtio_vsock: Enhance connection semantics Boeuf, Sebastien
2020-02-14  9:17 ` Stefano Garzarella
2020-02-14 10:23   ` Boeuf, Sebastien
2020-02-14 10:40     ` Stefano Garzarella [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200214104009.id33ew3uznvmitsb@steredhat \
    --to=sgarzare@redhat.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=sebastien.boeuf@intel.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox