From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E43EC3B1A1 for ; Fri, 14 Feb 2020 16:54:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E9CE020656 for ; Fri, 14 Feb 2020 16:54:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581699242; bh=lhYkUkKhNIN5XzZ3oL3+l7aoO6QBE7b9lZ90yaiKQ40=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=nTdbRBpOUd7rKDsbVw3ObsbcHrvb4W74swGfrhQzkC5AuTDGGGw/DOxv7gXyXSBUv TEcwrV2TzPQxFDIJjiUJyMDsD+QL1gZOuj4a+rbn4wmzaDhEhrqdi2lhu05y+iHtAm B8NiXryT7eRLpOr8jcst1LK8v0v/xXlhV7Z4oPBA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406776AbgBNQx6 (ORCPT ); Fri, 14 Feb 2020 11:53:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:51762 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404866AbgBNQSx (ORCPT ); Fri, 14 Feb 2020 11:18:53 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 745CA2470E; Fri, 14 Feb 2020 16:18:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581697132; bh=lhYkUkKhNIN5XzZ3oL3+l7aoO6QBE7b9lZ90yaiKQ40=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=c8XbUhGgrIb6SzC7QbOKR3tEFmjCpuf5S641JkaK7asKMGTwsyad4nIQACmk4BWJw v3eMuu1lZicRNjiBiUe1bveuu+830r50TOPigETTdHIuOBL5Saz9hKKKinRcPhLZt3 +Jq0N94tuAwtlJ1WRfMOjf7IepW8993jEJPimMc8= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Arnd Bergmann , kbuild test robot , "kernelci . org bot" , Olof's autobuilder , Stephen Rothwell , Greg Kroah-Hartman , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 075/186] isdn: don't mark kcapi_proc_exit as __exit Date: Fri, 14 Feb 2020 11:15:24 -0500 Message-Id: <20200214161715.18113-75-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200214161715.18113-1-sashal@kernel.org> References: <20200214161715.18113-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Arnd Bergmann [ Upstream commit b33bdf8020c94438269becc6dace9ed49257c4ba ] As everybody pointed out by now, my patch to clean up CAPI introduced a link time warning, as the two parts of the capi driver are now in one module and the exit function may need to be called in the error path of the init function: >> WARNING: drivers/isdn/capi/kernelcapi.o(.text+0xea4): Section mismatch in reference from the function kcapi_exit() to the function .exit.text:kcapi_proc_exit() The function kcapi_exit() references a function in an exit section. Often the function kcapi_proc_exit() has valid usage outside the exit section and the fix is to remove the __exit annotation of kcapi_proc_exit. Remove the incorrect __exit annotation. Reported-by: kbuild test robot Reported-by: kernelci.org bot Reported-by: Olof's autobuilder Reported-by: Stephen Rothwell Signed-off-by: Arnd Bergmann Link: https://lore.kernel.org/r/20191216194909.1983639-1-arnd@arndb.de Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/isdn/capi/kcapi_proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/capi/kcapi_proc.c b/drivers/isdn/capi/kcapi_proc.c index 68db3c5a10636..d6ca626219c93 100644 --- a/drivers/isdn/capi/kcapi_proc.c +++ b/drivers/isdn/capi/kcapi_proc.c @@ -309,7 +309,7 @@ kcapi_proc_init(void) proc_create("capi/driver", 0, NULL, &proc_driver_ops); } -void __exit +void kcapi_proc_exit(void) { remove_proc_entry("capi/driver", NULL); -- 2.20.1