Re: [PATCH net-next 03/10] net: add linkmode helper for setting flow control advertisement

[Andrew Lunn <andrew@lunn.ch>]

On Sat, Feb 15, 2020 at 03:49:32PM +0000, Russell King wrote:
> Add a linkmode helper to set the flow control advertisement in an
> ethtool linkmode mask according to the tx/rx capabilities. This
> implementation is moved from phylib, and documented with an
> analysis of its shortcomings.
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
>  drivers/net/phy/linkmode.c   | 51 ++++++++++++++++++++++++++++++++++++
>  drivers/net/phy/phy_device.c | 17 +-----------
>  include/linux/linkmode.h     |  2 ++
>  3 files changed, 54 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/net/phy/linkmode.c b/drivers/net/phy/linkmode.c
> index 969918795228..f60560fe3499 100644
> --- a/drivers/net/phy/linkmode.c
> +++ b/drivers/net/phy/linkmode.c
> @@ -42,3 +42,54 @@ void linkmode_resolve_pause(const unsigned long *local_adv,
>  	}
>  }
>  EXPORT_SYMBOL_GPL(linkmode_resolve_pause);
> +
> +/**
> + * linkmode_set_pause - set the pause mode advertisement
> + * @advertisement: advertisement in ethtool format
> + * @tx: boolean from ethtool struct ethtool_pauseparam tx_pause member
> + * @rx: boolean from ethtool struct ethtool_pauseparam rx_pause member
> + *
> + * Configure the advertised Pause and Asym_Pause bits according to the
> + * capabilities of provided in @tx and @rx.
> + *
> + * We convert as follows:
> + *  tx rx  Pause AsymDir
> + *  0  0   0     0
> + *  0  1   1     1
> + *  1  0   0     1
> + *  1  1   1     0
> + *
> + * Note: this translation from ethtool tx/rx notation to the advertisement
> + * is actually very problematical. Here are some examples:
> + *
> + * For tx=0 rx=1, meaning transmit is unsupported, receive is supported:
> + *
> + *  Local device  Link partner
> + *  Pause AsymDir Pause AsymDir Result
> + *    1     1       1     0     TX + RX - but we have no TX support.
> + *    1     1       0     1	Only this gives RX only
> + *
> + * For tx=1 rx=1, meaning we have the capability to transmit and receive
> + * pause frames:
> + *
> + *  Local device  Link partner
> + *  Pause AsymDir Pause AsymDir Result
> + *    1     0       0     1     Disabled - but since we do support tx and rx,
> + *				this should resolve to RX only.
> + *
> + * Hence, asking for:
> + *  rx=1 tx=0 gives Pause+AsymDir advertisement, but we may end up
> + *            resolving to tx+rx pause or only rx pause depending on
> + *            the partners advertisement.
> + *  rx=0 tx=1 gives AsymDir only, which will only give tx pause if
> + *            the partners advertisement allows it.
> + *  rx=1 tx=1 gives Pause only, which will only allow tx+rx pause
> + *            if the other end also advertises Pause.
> + */

It is good to document this.

With the change to netlink ethtool, we have the option to change the
interface to user space, or at least, easily add another way for
userspace to configure things. Maybe you can think of a better API?

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew