From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=5nYa=4D=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,
	SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id BECAEC7114D
	for <netdev@archiver.kernel.org>; Sat, 15 Feb 2020 18:57:06 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 7F00A20726
	for <netdev@archiver.kernel.org>; Sat, 15 Feb 2020 18:57:06 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="IWNMCRbf"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726610AbgBOS5F (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Sat, 15 Feb 2020 13:57:05 -0500
Received: from vps0.lunn.ch ([185.16.172.187]:47928 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726273AbgBOS5F (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sat, 15 Feb 2020 13:57:05 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=5sI3+8qpKoIzvaBHj5gl2VasMgvSjl6e7MLorisEb2Q=; b=IWNMCRbfnOYQujtdrGyRIsGgcw
        URHwMPTDhfqfX++JQ0HW8msR+eRhHDroOYXhBJ5+N043fPlIpasytjcfYOVZI8QPPJwgmiBEg/WF2
        PnDEirQ76vobnPfpHb6KtPYvJD0S9PSfFubuV62ryN6H34jYOfYrbgOYKNd7hYtsYu/8=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.93)
        (envelope-from <andrew@lunn.ch>)
        id 1j32cf-0005AR-KX; Sat, 15 Feb 2020 19:57:01 +0100
Date:   Sat, 15 Feb 2020 19:57:01 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Russell King <rmk+kernel@armlinux.org.uk>
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 04/10] net: phylink: remove pause mode ethtool
 setting for fixed links
Message-ID: <20200215185701.GU31084@lunn.ch>
References: <20200215154839.GR25745@shell.armlinux.org.uk>
 <E1j2zhJ-0003XT-V5@rmk-PC.armlinux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E1j2zhJ-0003XT-V5@rmk-PC.armlinux.org.uk>
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Sat, Feb 15, 2020 at 03:49:37PM +0000, Russell King wrote:
> Remove the ability for ethtool -A to change the pause settings for
> fixed links; if this is really required, we can reinstate it later.
> 
> Andrew Lunn agrees: "So I think it is safe to not implement ethtool
> -A, at least until somebody has a real use case for it."
> 
> Lets avoid making things too complex for use cases that aren't being
> used.
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew