From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 660A6C2BA83 for ; Sat, 15 Feb 2020 19:00:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 377F120726 for ; Sat, 15 Feb 2020 19:00:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="gdUXVhYr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726299AbgBOTAa (ORCPT ); Sat, 15 Feb 2020 14:00:30 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:47938 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726209AbgBOTAa (ORCPT ); Sat, 15 Feb 2020 14:00:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=TtPJ+qE+Eg6lpy2DJzJV/azNBZSNkn0sauiYHXoHjn0=; b=gdUXVhYrHCTfED8xFjE8Ajv+Ns q8hnY/D3xrqrpxiON5160AzjKU/FIaYGutlSmJJR3nIAGp1452Q4Ea05RmJP7JyUR2Y35x36pAD68 VrPzrYtlsoyFXzl2BvK01ui2BneQLtjolqwXHIhFLOJ5oexG82eCmrERx/aaFf6IOk/8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1j32fy-0005BL-5T; Sat, 15 Feb 2020 20:00:26 +0100 Date: Sat, 15 Feb 2020 20:00:26 +0100 From: Andrew Lunn To: Russell King Cc: Florian Fainelli , Heiner Kallweit , "David S. Miller" , netdev@vger.kernel.org Subject: Re: [PATCH net-next 05/10] net: phylink: ensure manual flow control is selected appropriately Message-ID: <20200215190026.GV31084@lunn.ch> References: <20200215154839.GR25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Feb 15, 2020 at 03:49:43PM +0000, Russell King wrote: > Split the application of manually controlled flow control modes from > phylink_resolve_flow(), so that we can use alternative providers of > flow control resolution. > > We also want to clear the MLO_PAUSE_AN flag when autoneg is disabled, > since flow control can't be negotiated in this circumstance. > > Signed-off-by: Russell King Reviewed-by: Andrew Lunn Andrew