From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7217C3402C for ; Mon, 17 Feb 2020 22:18:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 968F8214D8 for ; Mon, 17 Feb 2020 22:18:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726245AbgBQWSw (ORCPT ); Mon, 17 Feb 2020 17:18:52 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:56070 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726047AbgBQWSv (ORCPT ); Mon, 17 Feb 2020 17:18:51 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 3523015AA6301; Mon, 17 Feb 2020 14:18:51 -0800 (PST) Date: Mon, 17 Feb 2020 14:18:50 -0800 (PST) Message-Id: <20200217.141850.2134390863127670308.davem@davemloft.net> To: lorenzo.bianconi@redhat.com Cc: brouer@redhat.com, lorenzo@kernel.org, netdev@vger.kernel.org, ilias.apalodimas@linaro.org, dsahern@kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH net-next 4/5] net: mvneta: introduce xdp counters to ethtool From: David Miller In-Reply-To: <20200217102550.GB3080@localhost.localdomain> References: <882d9f03a8542cceec7c7b8e6d083419d84eaf7a.1581886691.git.lorenzo@kernel.org> <20200217111718.2c9ab08a@carbon> <20200217102550.GB3080@localhost.localdomain> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 17 Feb 2020 14:18:51 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Lorenzo Bianconi Date: Mon, 17 Feb 2020 11:25:50 +0100 > yes, I think it is definitely better. So to follow up: > - rename current "xdp_tx" counter in "xdp_xmit" and increment it for > XDP_TX verdict and for ndo_xdp_xmit > - introduce a new "xdp_tx" counter only for XDP_TX verdict. > > If we agree I can post a follow-up patch. What names do other drivers use? Consistency is important. I noticed while reviewing these patches that mellanox drivers export similar statistics in the exact same way.