From: Benjamin Poirier <bpoirier@cumulusnetworks.com>
To: David Ahern <dsahern@gmail.com>, Cong Wang <xiyou.wangcong@gmail.com>
Cc: netdev@vger.kernel.org, "Michal Kubeček" <mkubecek@suse.cz>,
"Nicolas Dichtel" <nicolas.dichtel@6wind.com>,
"Ido Schimmel" <idosch@idosch.org>
Subject: Re: [PATCH net 1/2] ipv6: Fix route replacement with dev-only route
Date: Mon, 17 Feb 2020 12:12:23 +0900 [thread overview]
Message-ID: <20200217031223.GA35587@f3> (raw)
In-Reply-To: <46537e63-1ba9-5e76-fad3-03cae4d0d60f@gmail.com>
On 2020/02/15 11:00 -0700, David Ahern wrote:
[...]
>
> Thanks for adding a test case. I take this to mean that all existing
> tests pass with this change. We have found this code to be extremely
> sensitive to seemingly obvious changes.
I saw two failures from that test suite, regardless of this change:
IPv4 rp_filter tests
TEST: rp_filter passes local packets [FAIL]
TEST: rp_filter passes loopback packets [FAIL]
The other tests, including the ipv6_rt group of tests, are OK.
The rp_filter tests fail for me even if I build a kernel from commit
adb701d6cfa4 ("selftests: add a test case for rp_filter")
Running the first ping manually, tcpdump shows:
root@vsid:~# tcpdump -nepi lo
tcpdump: verbose output suppressed, use -v or -vv for full protocol decode
listening on lo, link-type EN10MB (Ethernet), capture size 262144 bytes
12:01:12.618623 52:54:00:6a:c7:5e > 52:54:00:6a:c7:5e, ethertype IPv4 (0x0800), length 98: 198.51.100.1 > 198.51.100.1: ICMP echo request, id 616, seq 435, length 64
12:01:12.618650 52:54:00:6a:c7:5e > 52:54:00:6a:c7:5e, ethertype IPv4 (0x0800), length 98: 198.51.100.1 > 198.51.100.1: ICMP echo reply, id 616, seq 435, length 64
`ping` doesn't show any replies (since it's bound to dummy1...?).
Cong?
next prev parent reply other threads:[~2020-02-17 3:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 1:41 [PATCH net 1/2] ipv6: Fix route replacement with dev-only route Benjamin Poirier
2020-02-12 1:41 ` [PATCH net 2/2] ipv6: Fix nlmsg_flags when splitting a multipath route Benjamin Poirier
2020-02-12 21:58 ` Michal Kubecek
2020-02-15 17:58 ` David Ahern
2020-02-17 2:35 ` David Miller
2020-02-12 21:57 ` [PATCH net 1/2] ipv6: Fix route replacement with dev-only route Michal Kubecek
2020-02-15 18:00 ` David Ahern
2020-02-17 3:12 ` Benjamin Poirier [this message]
2020-02-20 3:20 ` Cong Wang
2020-02-17 2:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217031223.GA35587@f3 \
--to=bpoirier@cumulusnetworks.com \
--cc=dsahern@gmail.com \
--cc=idosch@idosch.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).