From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
To: Sven Eckelmann <sven@narfation.org>
Cc: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>,
mareklindner@neomailbox.ch, sw@simonwunderlich.de, a@unstable.cc,
davem@davemloft.net, b.a.t.m.a.n@lists.open-mesh.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
joel@joelfernandes.org, frextrite@gmail.com,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] net: batman-adv: Use built-in RCU list checking
Date: Mon, 17 Feb 2020 17:35:25 +0530 [thread overview]
Message-ID: <20200217120524.GA12888@madhuparna-HP-Notebook> (raw)
In-Reply-To: <14125758.fD4hS3u3Vl@sven-edge>
On Sun, Feb 16, 2020 at 05:17:36PM +0100, Sven Eckelmann wrote:
> On Sunday, 16 February 2020 16:52:44 CET Madhuparna Bhowmik wrote:
> [...]
> > > I understand this part. I was asking how you've identified them. Did you use
> > > any tool for that? coccinelle, sparse, ...
> >
> > Not really, I did it manually by inspecting each occurence.
>
> In that case, I don't understand why you didn't convert the occurrences from
> hlist_for_each_entry_rcu to hlist_for_each_entry [1]. Because a manual
> inspection should have noticed that there will always be the lock around
> these ones.
>
Hi Sven,
I have been working on similar issues (passing cond argument to
list_for_each_entry_Rcu()). That's why may be I didn't notice that in
this case rcu variant is not required.
Thank you for taking a closer look and fixing it the right way.
Regards,
Madhuparna
> KInd regards,
> Sven
>
> [1] https://www.kernel.org/doc/html/v5.6-rc1/RCU/whatisRCU.html#analogy-with-reader-writer-locking
prev parent reply other threads:[~2020-02-17 12:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-16 14:47 [PATCH] net: batman-adv: Use built-in RCU list checking madhuparnabhowmik10
2020-02-16 15:22 ` Sven Eckelmann
2020-02-16 15:33 ` Madhuparna Bhowmik
2020-02-16 15:35 ` Sven Eckelmann
2020-02-16 15:52 ` Madhuparna Bhowmik
2020-02-16 16:17 ` Sven Eckelmann
2020-02-17 12:05 ` Madhuparna Bhowmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217120524.GA12888@madhuparna-HP-Notebook \
--to=madhuparnabhowmik10@gmail.com \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=frextrite@gmail.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
--cc=sven@narfation.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox