From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
netdev@vger.kernel.org, ilias.apalodimas@linaro.org,
davem@davemloft.net, David Ahern <dsahern@kernel.org>,
BPF-dev-list <bpf@vger.kernel.org>,
brouer@redhat.com
Subject: Re: [PATCH net-next 4/5] net: mvneta: introduce xdp counters to ethtool
Date: Mon, 17 Feb 2020 15:51:38 +0100 [thread overview]
Message-ID: <20200217155139.6363aa52@carbon> (raw)
In-Reply-To: <20200217130515.GE32734@lunn.ch>
On Mon, 17 Feb 2020 14:05:15 +0100
Andrew Lunn <andrew@lunn.ch> wrote:
> On Mon, Feb 17, 2020 at 11:32:09AM +0100, Jesper Dangaard Brouer wrote:
> > On Mon, 17 Feb 2020 11:25:50 +0100
> > Lorenzo Bianconi <lorenzo.bianconi@redhat.com> wrote:
> >
[...]
> > >
> > > yes, I think it is definitely better. So to follow up:
> > > - rename current "xdp_tx" counter in "xdp_xmit" and increment it for
> > > XDP_TX verdict and for ndo_xdp_xmit
> > > - introduce a new "xdp_tx" counter only for XDP_TX verdict.
> > >
> > > If we agree I can post a follow-up patch.
> >
> > I agree, that sounds like an improvement to this patchset.
> >
> >
> > I suspect David Ahern have some opinions about more general stats for
> > XDP, but that it is a more general discussion, that it outside this
> > patchset, but we should also have that discussion.
>
> Hi Jesper
>
> I've not been following XDP too much, but xdp_xmit seems pretty
> generic. It would be nice if all drivers used the same statistics
> names. Less user confusion that way. So why is this outside of the
> discussion?
I do want to have this discussion, please.
I had hoped this patchset sparked this that discussion... maybe we can
have it despite this patchset already got applied?
My only request is that, if we don't revert, we fixup the "xdp_tx"
counter name. It would make it easier for us[1] if we can keep them
applied, as we are preparing (asciinema) demos for [1].
That said, I think it is rather important to standardize on same
statistics names across drivers... which is an assignment that Lorenzo
have already signed up for [2].
[1] https://netdevconf.info/0x14/session.html?tutorial-add-XDP-support-to-a-NIC-driver
[2] https://github.com/xdp-project/xdp-project/blob/master/planning.org#consistency-for-statistics-with-xdp
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2020-02-17 14:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-16 21:07 [PATCH net-next 0/5] add xdp ethtool stats to mvneta driver Lorenzo Bianconi
2020-02-16 21:07 ` [PATCH net-next 1/5] net: mvneta: move refill_err and skb_alloc_err in per-cpu stats Lorenzo Bianconi
2020-02-16 21:07 ` [PATCH net-next 2/5] net: mvneta: rely on open-coding updating stats for non-xdp and tx path Lorenzo Bianconi
2020-02-16 21:07 ` [PATCH net-next 3/5] net: mvneta: rely on struct mvneta_stats in mvneta_update_stats routine Lorenzo Bianconi
2020-02-16 21:07 ` [PATCH net-next 4/5] net: mvneta: introduce xdp counters to ethtool Lorenzo Bianconi
2020-02-17 10:17 ` Jesper Dangaard Brouer
2020-02-17 10:25 ` Lorenzo Bianconi
2020-02-17 10:32 ` Jesper Dangaard Brouer
2020-02-17 13:05 ` Andrew Lunn
2020-02-17 14:51 ` Jesper Dangaard Brouer [this message]
2020-02-17 18:17 ` David Ahern
2020-02-17 22:18 ` David Miller
2020-02-17 22:38 ` Lorenzo Bianconi
2020-02-16 21:07 ` [PATCH net-next 5/5] net: mvneta: get rid of xdp_ret in mvneta_swbm_rx_frame Lorenzo Bianconi
2020-02-17 4:04 ` [PATCH net-next 0/5] add xdp ethtool stats to mvneta driver David Miller
2020-02-17 9:58 ` Jesper Dangaard Brouer
2020-02-17 22:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217155139.6363aa52@carbon \
--to=brouer@redhat.com \
--cc=andrew@lunn.ch \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).