From: Andrew Lunn <andrew@lunn.ch>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 3/4] net: phy: add resolved pause support
Date: Tue, 18 Feb 2020 02:44:32 +0100 [thread overview]
Message-ID: <20200218014432.GC2171@lunn.ch> (raw)
In-Reply-To: <E1j3ij8-0006Ee-Lk@rmk-PC.armlinux.org.uk>
On Mon, Feb 17, 2020 at 03:54:30PM +0000, Russell King wrote:
> Allow phylib drivers to pass the hardware-resolved pause state to MAC
> drivers, rather than using the software-based pause resolution code.
Hi Russell
What i find missing here is an explanation of why hardware resolved
pause is better than software. We know what the software based method
is, and it will be consistent across all hardware. Can we say that
about the hardware?
Thanks
Andrew
next prev parent reply other threads:[~2020-02-18 1:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 15:53 [PATCH net-next 0/4] phylib: add hardware resolved pause mode support for marvell PHYs Russell King - ARM Linux admin
2020-02-17 15:54 ` [PATCH net-next 1/4] net: phy: marvell10g: read copper results from CSSR1 Russell King
2020-02-18 1:37 ` Andrew Lunn
2020-02-17 15:54 ` [PATCH net-next 2/4] net: phy: marvell: don't interpret PHY status unless resolved Russell King
2020-02-18 1:38 ` Andrew Lunn
2020-02-17 15:54 ` [PATCH net-next 3/4] net: phy: add resolved pause support Russell King
2020-02-18 1:44 ` Andrew Lunn [this message]
2020-02-17 15:54 ` [PATCH net-next 4/4] net: phy: marvell*: add support for hw resolved pause modes Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218014432.GC2171@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).