From: Andrew Lunn <andrew@lunn.ch>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Ido Schimmel <idosch@idosch.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] net: dsa: mv88e6xxx: fix duplicate vlan warning
Date: Tue, 18 Feb 2020 17:27:50 +0100 [thread overview]
Message-ID: <20200218162750.GR31084@lunn.ch> (raw)
In-Reply-To: <20200218115157.GG25745@shell.armlinux.org.uk>
On Tue, Feb 18, 2020 at 11:51:57AM +0000, Russell King - ARM Linux admin wrote:
> On Tue, Feb 18, 2020 at 11:46:14AM +0000, Russell King wrote:
> > When setting VLANs on DSA switches, the VLAN is added to both the port
> > concerned as well as the CPU port by dsa_slave_vlan_add(). If multiple
> > ports are configured with the same VLAN ID, this triggers a warning on
> > the CPU port.
> >
> > Avoid this warning for CPU ports.
> >
> > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
>
> Note that there is still something not right. On the ZII dev rev B,
> setting up a bridge across all the switch ports, I get:
Hi Russell
FYI: You need to be a little careful with VLANs on rev B. The third
switch does not have the PVT hardware. So VLANs are going to 'leak'
when they cross the DSA link to that switch.
I will look at these patches later today.
Andrew
next prev parent reply other threads:[~2020-02-18 16:28 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 11:45 [PATCH net-next 0/3] VLANs, DSA switches and multiple bridges Russell King - ARM Linux admin
2020-02-18 11:46 ` [PATCH net-next 1/3] net: switchdev: do not propagate bridge updates across bridges Russell King
2020-02-18 11:46 ` [PATCH net-next 2/3] net: dsa: mv88e6xxx: fix duplicate vlan warning Russell King
2020-02-18 11:51 ` Russell King - ARM Linux admin
2020-02-18 16:27 ` Andrew Lunn [this message]
2020-02-18 16:31 ` Russell King - ARM Linux admin
2020-02-20 18:12 ` Russell King - ARM Linux admin
2020-02-18 11:46 ` [PATCH net-next 3/3] net: dsa: mv88e6xxx: fix vlan setup Russell King
2020-02-18 19:09 ` Vivien Didelot
2020-02-18 19:34 ` Florian Fainelli
2020-02-18 23:48 ` Russell King - ARM Linux admin
2020-02-19 0:52 ` Vivien Didelot
2020-02-18 19:26 ` [PATCH net-next 0/3] VLANs, DSA switches and multiple bridges Florian Fainelli
2020-02-19 0:00 ` Florian Fainelli
2020-02-19 0:17 ` Russell King - ARM Linux admin
2020-02-19 0:33 ` Florian Fainelli
2020-02-19 0:58 ` Vivien Didelot
2020-02-19 3:47 ` Andrew Lunn
2020-02-19 9:19 ` Russell King - ARM Linux admin
2020-02-19 18:07 ` Vivien Didelot
2020-02-19 18:20 ` Florian Fainelli
2020-02-20 11:35 ` Russell King - ARM Linux admin
2020-02-19 18:52 ` Vladimir Oltean
2020-02-19 19:18 ` Florian Fainelli
2020-02-19 23:15 ` Russell King - ARM Linux admin
2020-02-20 18:56 ` Florian Fainelli
2020-02-21 0:21 ` Russell King - ARM Linux admin
2020-03-16 11:15 ` Russell King - ARM Linux admin
2020-03-17 12:00 ` Russell King - ARM Linux admin
2020-03-17 14:21 ` Vladimir Oltean
2020-03-17 15:12 ` Russell King - ARM Linux admin
2020-03-17 18:49 ` Vivien Didelot
2020-03-17 21:24 ` Russell King - ARM Linux admin
2020-03-18 2:26 ` Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218162750.GR31084@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=idosch@idosch.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).