From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A001C34031 for ; Tue, 18 Feb 2020 23:48:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C1392173E for ; Tue, 18 Feb 2020 23:48:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="MYwJWGcz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726891AbgBRXsS (ORCPT ); Tue, 18 Feb 2020 18:48:18 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:33238 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726461AbgBRXsS (ORCPT ); Tue, 18 Feb 2020 18:48:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=sYBK+hjxHOSyJ0cblfH2VNIbIJzTu4XFcpaB69wTeWk=; b=MYwJWGczxQd4fFetHU1cgxSuX kqFCTwhwAz55L5vJPt+ntJBh4iSk0yaI5iZZpD0q68AbR8dBgIXOxFWoxNe0jieOSOezGgxC/y3Q1 tJ6F/bv9WAmkOXfwbTPRCKmDvJf1SdpndlbXI+sunYl1HiFNUMNyjN9U5jp8I/hNUVfCl55tR+brx zQBr4JrcoKyzVfvm8pcvClKYHzPfT98TeExww4WMj4SPFXdJF0vHqwhe0MKAJOYRqQfkVjSgR0gL3 166igm0HVCrOS8T4Wrc2tGUQWrVe19ik9fZqCCDQSeqxuq6MgPyYehzbgA8cQM42uUoXJ2U8om3It 3iQyx3nGw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:53832) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1j4Cb4-0001v7-DF; Tue, 18 Feb 2020 23:48:10 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1j4Cb1-0000qa-05; Tue, 18 Feb 2020 23:48:07 +0000 Date: Tue, 18 Feb 2020 23:48:06 +0000 From: Russell King - ARM Linux admin To: Florian Fainelli Cc: Vivien Didelot , Andrew Lunn , Heiner Kallweit , Ido Schimmel , "David S. Miller" , netdev@vger.kernel.org, Jakub Kicinski Subject: Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: fix vlan setup Message-ID: <20200218234806.GN25745@shell.armlinux.org.uk> References: <20200218114515.GL18808@shell.armlinux.org.uk> <20200218140907.GB15095@t480s.localdomain> <3bfda6cc-5108-427f-e225-beba0f809d73@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3bfda6cc-5108-427f-e225-beba0f809d73@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Feb 18, 2020 at 11:34:38AM -0800, Florian Fainelli wrote: > Russell, in your tests/examples, did the tagged traffic of $VN continue > to work after you toggled vlan_filtering on? If so, that must be because > on a bridge with VLAN filtering disabled, we still ended up calling down > to the lan1..6 ndo_vlan_rx_add_vid() and so we do have VLAN entries > programmed for $VN. >From what I remember, _all_ traffic was blocked because the VTU was completely empty when vlan filtering is turned on. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up