From: "Guo-Fu Tseng" <cooldavid@cooldavid.org>
To: Heiner Kallweit <hkallweit1@gmail.com>,
David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2 07/13] jme: use new helper tcp_v6_gso_csum_prep
Date: Wed, 19 Feb 2020 11:53:48 +0800 [thread overview]
Message-ID: <20200219034801.M31679@cooldavid.org> (raw)
In-Reply-To: <f9f6897b-8dc8-2036-97d4-60e154b57356@gmail.com>
On Tue, 18 Feb 2020 21:06:11 +0100, Heiner Kallweit wrote
> Use new helper tcp_v6_gso_csum_prep in additional network drivers.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/net/ethernet/jme.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c
> index 2e4975572..de3c7ce93 100644
> --- a/drivers/net/ethernet/jme.c
> +++ b/drivers/net/ethernet/jme.c
> @@ -2077,12 +2077,7 @@ jme_tx_tso(struct sk_buff *skb, __le16 *mss, u8 *flags)
> IPPROTO_TCP,
> 0);
> } else {
> - struct ipv6hdr *ip6h = ipv6_hdr(skb);
> -
> - tcp_hdr(skb)->check = ~csum_ipv6_magic(&ip6h->saddr,
> - &ip6h->daddr, 0,
> - IPPROTO_TCP,
> - 0);
> + tcp_v6_gso_csum_prep(skb);
> }
>
> return 0;
> --
> 2.25.1
Kallweit:
Looks good to me. Thank you.
Guo-Fu Tseng
next prev parent reply other threads:[~2020-02-19 4:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 19:55 [PATCH net-next v2 0/13] net: core: add helper tcp_v6_gso_csum_prep Heiner Kallweit
2020-02-18 19:56 ` [PATCH net-next v2 01/13] " Heiner Kallweit
2020-02-18 19:58 ` [PATCH net-next v2 02/13] r8169: use new " Heiner Kallweit
2020-02-18 19:59 ` [PATCH net-next v2 03/13] net: atheros: " Heiner Kallweit
2020-02-18 20:01 ` [PATCH net-next v2 04/13] bna: " Heiner Kallweit
2020-02-18 20:02 ` [PATCH net-next v2 05/13] enic: " Heiner Kallweit
2020-02-18 20:05 ` [PATCH net-next v2 06/13] e1000(e): " Heiner Kallweit
2020-02-18 21:49 ` Jeff Kirsher
2020-02-18 20:06 ` [PATCH net-next v2 07/13] jme: " Heiner Kallweit
2020-02-19 3:53 ` Guo-Fu Tseng [this message]
2020-02-18 20:07 ` [PATCH net-next v2 08/13] ionic: " Heiner Kallweit
2020-02-18 22:56 ` Shannon Nelson
2020-02-18 20:08 ` [PATCH net-next v2 09/13] net: qcom/emac: " Heiner Kallweit
2020-02-18 20:09 ` [PATCH net-next v2 10/13] net: socionext: " Heiner Kallweit
2020-02-19 12:36 ` Ilias Apalodimas
2020-02-18 20:11 ` [PATCH net-next v2 11/13] hv_netvsc: " Heiner Kallweit
2020-02-18 20:12 ` [PATCH net-next v2 12/13] r8152: " Heiner Kallweit
2020-02-19 9:48 ` Hayes Wang
2020-02-18 20:13 ` [PATCH net-next v2 13/13] vmxnet3: " Heiner Kallweit
2020-02-19 19:22 ` [PATCH net-next v2 0/13] net: core: add " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219034801.M31679@cooldavid.org \
--to=cooldavid@cooldavid.org \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).