[RFC PATCH v2 19/22] devlink: remove unnecessary parameter from chunk_fill function

Jacob Keller
2020-02-14T23:22:56Z

The devlink parameter of the devlink_nl_cmd_region_read_chunk_fill
function is not used. Remove it, to simplify the function signature.

Once removed, it is also obvious that the devlink parameter is not
necessary for the devlink_nl_region_read_snapshot_fill either.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
---
net/core/devlink.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/net/core/devlink.c b/net/core/devlink.c
index e81b56f83128..a722272f42b4 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -4111,7 +4111,6 @@ devlink_nl_cmd_region_new(struct sk_buff *skb, struct genl_info *info)
}

static int devlink_nl_cmd_region_read_chunk_fill(struct sk_buff *msg,
- struct devlink *devlink,
u8 *chunk, u32 chunk_size,
u64 addr)
{
@@ -4143,7 +4142,6 @@ static int devlink_nl_cmd_region_read_chunk_fill(struct sk_buff *msg,

static int
devlink_nl_region_read_snapshot_fill(struct sk_buff *skb,
- struct devlink *devlink,
struct devlink_snapshot *snapshot,
u64 start_offset,
u64 end_offset,
@@ -4160,8 +4158,8 @@ devlink_nl_region_read_snapshot_fill(struct sk_buff *skb,
u8 *data;

data = &snapshot->data[curr_offset];
- err = devlink_nl_cmd_region_read_chunk_fill(skb, devlink,
- data, data_size,
+ err = devlink_nl_cmd_region_read_chunk_fill(skb, data,
+ data_size,
curr_offset);
if (err)
break;
@@ -4272,9 +4270,8 @@ static int devlink_nl_cmd_region_read_dumpit(struct sk_buff *skb,
end_offset = region->size;
}

- err = devlink_nl_region_read_snapshot_fill(skb, devlink, snapshot,
- start_offset, end_offset,
- &ret_offset);
+ err = devlink_nl_region_read_snapshot_fill(skb, snapshot, start_offset,
+ end_offset, &ret_offset);

if (err && err != -EMSGSIZE)
goto nla_put_failure;
--
2.25.0.368.g28a2d05eebfb