From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6989C18E00 for ; Wed, 19 Feb 2020 20:20:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 92A0B24670 for ; Wed, 19 Feb 2020 20:20:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="mAQK9Gss" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727326AbgBSUUM (ORCPT ); Wed, 19 Feb 2020 15:20:12 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:54268 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726645AbgBSUUL (ORCPT ); Wed, 19 Feb 2020 15:20:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=KAdl9nkfoq9a8f1apc9MyNEY0KMLJnsiy/JC7l/c7WU=; b=mAQK9Gssdh2vlWVYIplASIKeuv I020YSQRqJgT3/iqz3rD3dzEjKu5NZJX5IpW44Lwvxh8T3hlitpAGBI/YBLzqyF+JAyO7S1JStgLX XcctJxsd9Vr+MyKcPNPHvtBxvstwreQBku7TWUXL2jhmqq19jWD/HEJp+iOEQDIzupCE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1j4VpG-0002GX-Q0; Wed, 19 Feb 2020 21:20:06 +0100 Date: Wed, 19 Feb 2020 21:20:06 +0100 From: Andrew Lunn To: Florian Fainelli Cc: netdev@vger.kernel.org, Heiner Kallweit , Russell King , "David S. Miller" , open list Subject: Re: [PATCH net-next v2 2/3] net: phy: broadcom: Have bcm54xx_adjust_rxrefclk() check for flags Message-ID: <20200219202006.GY31084@lunn.ch> References: <20200219200049.12512-1-f.fainelli@gmail.com> <20200219200049.12512-3-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200219200049.12512-3-f.fainelli@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Feb 19, 2020 at 12:00:48PM -0800, Florian Fainelli wrote: > bcm54xx_adjust_rxrefclk() already checks for PHY_BRCM_AUTO_PWRDWN_ENABLE > and PHY_BRCM_DIS_TXCRXC_NOENRGY in order to set the appropriate bit. The > situation is a bit more complicated with the flag > PHY_BRCM_RX_REFCLK_UNUSED but essentially amounts to the same situation. > > The default setting for the 125MHz clock is to be on for all PHYs and > we still treat BCM50610 and BCM50610M specifically with the polarity of > the bit reversed. > > Signed-off-by: Florian Fainelli Reviewed-by: Andrew Lunn Andrew