netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: rkir@google.com
To: davem@davemloft.net, kuba@kernel.org
Cc: rammuthiah@google.com, adelva@google.com, lfy@google.com,
	netdev@vger.kernel.org, Roman Kiryanov <rkir@google.com>
Subject: [PATCH v2] net: disable BRIDGE_NETFILTER by default
Date: Wed, 19 Feb 2020 13:40:06 -0800	[thread overview]
Message-ID: <20200219214006.175275-1-rkir@google.com> (raw)

From: Roman Kiryanov <rkir@google.com>

The description says 'If unsure, say N.' but
the module is built as M by default (once
the dependencies are satisfied).

When the module is selected (Y or M), it enables
NETFILTER_FAMILY_BRIDGE and SKB_EXTENSIONS
which alter kernel internal structures.

We (Android Studio Emulator) currently do not
use this module and think this it is more consistent
to have it disabled by default as opposite to
disabling it explicitly to prevent enabling
NETFILTER_FAMILY_BRIDGE and SKB_EXTENSIONS.

Signed-off-by: Roman Kiryanov <rkir@google.com>
---
Changes in v2:
 - added cc:netdev@vger.kernel.org

 net/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/Kconfig b/net/Kconfig
index b0937a700f01..2eeb0e55f7c9 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -189,7 +189,6 @@ config BRIDGE_NETFILTER
 	depends on NETFILTER_ADVANCED
 	select NETFILTER_FAMILY_BRIDGE
 	select SKB_EXTENSIONS
-	default m
 	---help---
 	  Enabling this option will let arptables resp. iptables see bridged
 	  ARP resp. IP traffic. If you want a bridging firewall, you probably
-- 
2.25.0.265.gbab2e86ba0-goog


             reply	other threads:[~2020-02-19 21:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-19 21:40 rkir [this message]
2020-02-20 13:11 ` [PATCH v2] net: disable BRIDGE_NETFILTER by default Florian Westphal
2020-02-20 23:02 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200219214006.175275-1-rkir@google.com \
    --to=rkir@google.com \
    --cc=adelva@google.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=lfy@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=rammuthiah@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).