From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A5F9C11D83 for ; Wed, 19 Feb 2020 22:30:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 295962467B for ; Wed, 19 Feb 2020 22:21:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="gOKjOtmH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727636AbgBSWVM (ORCPT ); Wed, 19 Feb 2020 17:21:12 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:54400 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726760AbgBSWVM (ORCPT ); Wed, 19 Feb 2020 17:21:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=rEr0lTeockNjXTKUWfbUWgXlvTp8sYO0SIkMHrOrdkg=; b=gOKjOtmHkZpQtji5vmITgJJr+Q XME8ujB28RAKKcCUp8d/PqiaCwRBeZu8WwU8XwSoZN000bRzl6mzPcg1urCBT/Cn5ka0knmDeic/Q CmyXkVVOy5Oqtqhow979QTRvnhMx4RcsWjQRXu+E73jvawnXxZpHXI1qEAvxsOeHnUWU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1j4XiJ-0002iE-Vt; Wed, 19 Feb 2020 23:21:03 +0100 Date: Wed, 19 Feb 2020 23:21:03 +0100 From: Andrew Lunn To: Heiner Kallweit Cc: Florian Fainelli , Russell King - ARM Linux , David Miller , Realtek linux nic maintainers , "netdev@vger.kernel.org" Subject: Re: [PATCH net-next 1/2] net: phy: unregister MDIO bus in _devm_mdiobus_free if needed Message-ID: <20200219222103.GZ31084@lunn.ch> References: <15ee7621-0e74-a3c1-0778-ca4fa6c2e3c6@gmail.com> <913abdae-0617-b411-7eaa-599588f95e32@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <913abdae-0617-b411-7eaa-599588f95e32@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Feb 17, 2020 at 09:34:57PM +0100, Heiner Kallweit wrote: > If using managed MDIO bus handling (devm_mdiobus_alloc et al) we still > have to manually unregister the MDIO bus. For drivers that don't depend > on unregistering the MDIO bus at a specific, earlier point in time we > can make driver author's life easier by automagically unregistering > the MDIO bus. This extension is transparent to existing drivers. > > Signed-off-by: Heiner Kallweit > --- > drivers/net/phy/mdio_bus.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c > index 9bb9f37f2..6af51cbdb 100644 > --- a/drivers/net/phy/mdio_bus.c > +++ b/drivers/net/phy/mdio_bus.c > @@ -170,7 +170,12 @@ EXPORT_SYMBOL(mdiobus_alloc_size); > > static void _devm_mdiobus_free(struct device *dev, void *res) > { > - mdiobus_free(*(struct mii_bus **)res); > + struct mii_bus *bus = *(struct mii_bus **)res; > + > + if (bus->state == MDIOBUS_REGISTERED) > + mdiobus_unregister(bus); > + > + mdiobus_free(bus); > } Hi Heiner The API is rather asymmetric. The alloc is not just setting up a free, but also an unregister. Are there other examples of this in the kernel? Maybe a devm_of_mdiobus_register() would be better? It is then clear that the unregister happens because of this call, and the free because of the devm_mdiobus_alloc(). Andrew