From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E438FC11D05 for ; Thu, 20 Feb 2020 11:20:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B18AD207FD for ; Thu, 20 Feb 2020 11:20:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582197654; bh=Jp1RQZF8hLT8E2hu5n/YvUZMWBwsoJaU4Yvt5ycGIXQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=RTPateIHYnncpYeIL/jZw4PC6wVA28kAENDMxkHguWZxcBgWvD3NkJ0BAEwpLGNWj XzsUAGak8TxLMzK5zr0+vc4xS39PjZAjFaEmvMksKXjGiomOJNdhWvEUuiBydCvEYA 9OHZT+CVpmheJfHyDt/QfxN4ItJXP5YwNYqLE/i8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727649AbgBTLUw (ORCPT ); Thu, 20 Feb 2020 06:20:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:51682 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726501AbgBTLUw (ORCPT ); Thu, 20 Feb 2020 06:20:52 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1C8BC207FD; Thu, 20 Feb 2020 11:20:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582197651; bh=Jp1RQZF8hLT8E2hu5n/YvUZMWBwsoJaU4Yvt5ycGIXQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YK9w8LcKch7k67N+sqdukZGZ53h6U2iWnllYNMJO//z0BZlrjQOQOWgPMXN68ZR+e iOWn/S06KtjVb705/Br9Q9S02Y1dCyQE9OkP0569rLWnPhLo0A5Gv+63jLlviWNK2C CgPg1k4FzeFRFw7ottO7w0yu/yDPzIOC/d2pj8fo= Date: Thu, 20 Feb 2020 12:20:49 +0100 From: Greg Kroah-Hartman To: Christian Brauner Cc: "David S. Miller" , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, "Rafael J. Wysocki" , Pavel Machek , Jakub Kicinski , Eric Dumazet , Stephen Hemminger , linux-pm@vger.kernel.org Subject: Re: [PATCH net-next v3 1/9] sysfs: add sysfs_file_change_owner{_by_name}() Message-ID: <20200220112049.GF3374196@kroah.com> References: <20200218162943.2488012-1-christian.brauner@ubuntu.com> <20200218162943.2488012-2-christian.brauner@ubuntu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200218162943.2488012-2-christian.brauner@ubuntu.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Feb 18, 2020 at 05:29:35PM +0100, Christian Brauner wrote: > +/** > + * sysfs_file_change_owner - change owner of a file. > + * @kobj: object. > + * @kuid: new owner's kuid > + * @kgid: new owner's kgid > + */ > +int sysfs_file_change_owner(struct kobject *kobj, kuid_t kuid, kgid_t kgid) > +{ > + struct kernfs_node *kn; > + int error; > + > + if (!kobj->state_in_sysfs) > + return -EINVAL; > + > + kernfs_get(kobj->sd); > + > + kn = kobj->sd; > + error = internal_change_owner(kn, kobj, kuid, kgid); > + > + kernfs_put(kn); > + > + return error; > +} > +EXPORT_SYMBOL_GPL(sysfs_file_change_owner); Oops, wait, what "file" are you changing here? You aren't changing the kobject's attributes, but rather a file in the kobject's directory, right? But kobj->sd is the directory of the kobject itself, so why isn't this function just the same thing as sysfs_change_owner()? Why would you call this function at all? confused, greg k-h