From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F867C11D05 for ; Thu, 20 Feb 2020 11:35:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1377C2467C for ; Thu, 20 Feb 2020 11:35:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="SLaYk7g0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727868AbgBTLft (ORCPT ); Thu, 20 Feb 2020 06:35:49 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:58762 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726825AbgBTLft (ORCPT ); Thu, 20 Feb 2020 06:35:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=UwV1E9IpH6lihvWwJsEF1r0v9DXIq2lNrBTyIa7NBJs=; b=SLaYk7g0u9SmAf++2bbKkFucB Jf1SMVuuyMdAiYfi/5Eg5Ky03tpm80TQxqsRmnRTk4tiLWzCWZOka3n0MulN+JNBivxomYRF+HHJ5 n7FO9sNNXXUW6Bv3hiWDBT7nVKdxRtXncHWK6quvoUn3475s5xnKdXLytwVWSi9Uh9JttyZqhdenp lR8/ftcfHOYc31NQGQZyishTclmj+07gtTlFj2ZH7SKcAGbx4UDDUQVg2oFcIeBXGbGXTQPX2qtiN kIc6HDssF1PrphQ/ejKKRbUqVOUohgW6WdAx4n8FLVEFDsHE3Cbt9JhykpUnotzvzIKb1kmfpZsFy 37rJyxDXQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:54510) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1j4k7A-0002z2-TI; Thu, 20 Feb 2020 11:35:33 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1j4k76-0002O0-P5; Thu, 20 Feb 2020 11:35:28 +0000 Date: Thu, 20 Feb 2020 11:35:28 +0000 From: Russell King - ARM Linux admin To: Vivien Didelot Cc: Andrew Lunn , Florian Fainelli , Heiner Kallweit , Ido Schimmel , "David S. Miller" , Ivan Vecera , Jakub Kicinski , Jiri Pirko , netdev@vger.kernel.org Subject: Re: [PATCH net-next 0/3] VLANs, DSA switches and multiple bridges Message-ID: <20200220113528.GY25745@shell.armlinux.org.uk> References: <20200218114515.GL18808@shell.armlinux.org.uk> <20200219001737.GP25745@shell.armlinux.org.uk> <20200219034730.GE10541@lunn.ch> <20200219091900.GQ25745@shell.armlinux.org.uk> <20200219130707.GB245247@t480s.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200219130707.GB245247@t480s.localdomain> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Feb 19, 2020 at 01:07:07PM -0500, Vivien Didelot wrote: > Hi Russell, > > Some switches like the Marvell 88E6060 don't have a VTU, so programming the > default PVID would return -EOPNOTSUPP. The 88e6060 has its own driver separate from mv88e6xxx. > Switches supporting only global VLAN > filtering cannot have a VLAN filtering aware bridge as well as a non VLAN > filtering aware bridge spanning their ports at the same time. But all this > shouldn't be a problem because drivers inform the stack whether they support > ds->vlan_filtering per-port, globally or not. We should simply reject the > operation when vlan_filtering is being enabled on unsupported hardware. > > Linux bridge is the reference for the implementation of an Ethernet bridge, > if it programs VLAN entries, supported DSA hardware must do so. I'm not a > fan of having our own bridge logic in DSA, so the limitation implemented by > 2ea7a679ca2a ("net: dsa: Don't add vlans when vlan filtering is disabled") > needs to go in my opinion. ... which is basically what patch 3 is doing, but in a per-driver manner. The checks introduced in 2ea7a679ca2a ("net: dsa: Don't add vlans when vlan filtering is disabled") were raised up a level by c5335d737ff3 ("net: dsa: check bridge VLAN in slave operations") to their present positions, which are then touched by my patch 3 to make the checks conditional. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up