From: Richard Cochran <richardcochran@gmail.com>
To: min.li.xe@renesas.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 2/2] ptp: Add a ptp clock driver for IDT 82P33 SMU.
Date: Fri, 21 Feb 2020 09:19:12 -0800 [thread overview]
Message-ID: <20200221171912.GA5673@localhost> (raw)
In-Reply-To: <20200221115128.GA1692@localhost>
On Fri, Feb 21, 2020 at 03:51:28AM -0800, Richard Cochran wrote:
> > + channel->ptp_clock = ptp_clock_register(&channel->caps, NULL);
> > +
> > + if (IS_ERR(channel->ptp_clock)) {
> > + err = PTR_ERR(channel->ptp_clock);
> > + channel->ptp_clock = NULL;
> > + return err;
> > + }
>
> The function, ptp_clock_register(), can also return NULL. Please
> handle that case as well.
>
> > +
> > + if (!channel->ptp_clock)
> > + return -ENOTSUPP;
Duh! Never mind that last comment!
Thanks,
Richard
prev parent reply other threads:[~2020-02-21 17:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 21:28 [PATCH net-next v3 2/2] ptp: Add a ptp clock driver for IDT 82P33 SMU min.li.xe
2020-02-21 11:51 ` Richard Cochran
2020-02-21 17:19 ` Richard Cochran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200221171912.GA5673@localhost \
--to=richardcochran@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=min.li.xe@renesas.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).