From: Jiri Pirko <jiri@resnulli.us>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jiri Pirko <jiri@mellanox.com>
Subject: Re: [PATCH net] net: genetlink: return the error code when attribute parsing fails.
Date: Sat, 22 Feb 2020 07:54:42 +0100 [thread overview]
Message-ID: <20200222065442.GC2228@nanopsycho> (raw)
In-Reply-To: <933cec10232417777c5a214e25a31d1f299d1489.1582310461.git.pabeni@redhat.com>
Fri, Feb 21, 2020 at 07:42:13PM CET, pabeni@redhat.com wrote:
>Currently if attribute parsing fails and the genl family
>does not support parallel operation, the error code returned
>by __nlmsg_parse() is discarded by genl_family_rcv_msg_attrs_parse().
>
>Be sure to report the error for all genl families.
>
>Fixes: c10e6cf85e7d ("net: genetlink: push attrbuf allocation and parsing to a separate function")
>Fixes: ab5b526da048 ("net: genetlink: always allocate separate attrs for dumpit ops")
>Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Thanks!
next prev parent reply other threads:[~2020-02-22 6:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 18:42 [PATCH net] net: genetlink: return the error code when attribute parsing fails Paolo Abeni
2020-02-22 6:54 ` Jiri Pirko [this message]
2020-02-23 6:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200222065442.GC2228@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox